[Debian] device-image-upload with --bmc or --retimer-included failed with error "Expecting value: line 1 column 1 (char 0)"

[Mohammad Issa]

Brief Description

device-image-upload with --bmc or --retimer-included failed with error "Expecting value: line 1 column 1 (char 0)"

Note: device-image-upload WITHOUT --bmc or --retimer-included works

Severity

Major

Steps to Reproduce

system device-image-upload VistaCreekBravoBMCFW_Release_WW16.1.bin functional 8086 0b30 --bitstream-id 32 --bmc true --retimer-included true

Expected Behavior

image is uploaded

Actual Behavior

image upload failed with error "Expecting value: line 1 column 1 (char 0)"

Reproducibility

reproducible

System Configuration

wp_15

Branch/Pull Time/Commit

stx-debian-pipeline 2022-06-07_19-00-50

Last Pass

Centos build

Timestamp/Logs
[sysadmin@controller-0 pkvl_update_rollback(keystone_admin)]$ system device-image-upload VistaCreekBravoBMCFW_Release_WW16.1.bin functional 8086 0b30 --bitstream-id 35 --bmc true --retimer-included true

Device image not uploaded for VistaCreekBravoBMCFW_Release_WW16.1.bin: Expecting value: line 1 column 1 (char 0)

Without --bmc true --retimer-included true
[sysadmin@controller-0 pkvl_update_rollback(keystone_admin)]$ system device-image-upload VistaCreekBravoBMCFW_Release_WW16.1.bin functional 8086 0b30 --bitstream-id 35

+------------------+--------------------------------------+
| Property | Value |
+------------------+--------------------------------------+
| uuid | 70d3f3a0-7719-4f54-871e-ba49958c9cd3 |
| bitstream_type | functional |
| pci_vendor | 8086 |
| pci_device | 0b30 |
| bitstream_id | 35 |
| key_signature | None |
| revoke_key_id | None |
| name | None |
| description | None |
| image_version | None |
| applied | False |
| applied_labels | |
| bmc | False |
| retimer_included | False |
+------------------+--------------------------------------+
Test Activity

Regression Testing

Workaround

Describe workaround if available

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/848647

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/848647
Committed: https://opendev.org/starlingx/config/commit/109eb6e7f31a3a20683008fd839a6d9ccd3e61c6
Submitter: "Zuul (22348)"
Branch: master

commit 109eb6e7f31a3a20683008fd839a6d9ccd3e61c6
Author: Mohammad Issa <email address hidden>
Date: Thu Jun 30 20:56:03 2022 +0000

    Device image upload with bmc type error

    device-image-upload with --bmc or --retimer-included failed with
    error: "Expecting value: line 1 column 1 (char 0)"
    Note: device-image-upload WITHOUT --bmc or --retimer-included works

    The parameters for 'bmc' and 'retimer_included' (ex. True or False)
    are passed in as strings instead of boolean.

    Unit test case passes in parameters as strings, if strtobool
    conversion works it will not catch an error

    Test Plan:

    PASS: Intercept the data Dictionary and override values corresponding
          to their keys with the correct values.
          Then use this command to test:
         "system device-image-upload VistaCreekBravoBMCFW_Release_WW16.1.bin
         functional 8086 0b30 --bitstream-id 32 --bmc true
         --retimer-included true"
         --> Command Response:
             +------------------+--------------------------------------+
             | Property | Value |
             +------------------+--------------------------------------+
             | uuid | d54038e6-4174-48e0-943e-a7bdfa1caf07 |
             | bitstream_type | functional |
             | pci_vendor | 8086 |
             | pci_device | 0b30 |
             | bitstream_id | 35 |
             | key_signature | None |
             | revoke_key_id | None |
             | name | None |
             | description | None |
             | image_version | None |
             | applied | False |
             | applied_labels | |
             | bmc | True |
             | retimer_included | True |
             +------------------+--------------------------------------+

    Closes-Bug: 1980405

    Signed-off-by: Mohammad Issa <email address hidden>
    Change-Id: I79ea7661b1bc383df5daa6f4f93efd4df0e7bb2b