Host_based "ptp=no-lock" alarm set for Debian, cannot clear

[Douglas Henrique Koerich]

Brief Description
-----------------
In Debian-based StarlingX installation, after configuring ptp instances on Debian, the following alarm is always is displayed, even though the ptp4l instances are locked and in sync:

100.119 controller-0 is not locked to remote PTP Grand Master host=controller-0.ptp=no-lock major

Severity
--------
Minor

Steps to Reproduce
------------------
Configure ptp4l instances and lock the host to an external GM or GNSS antena, then verify the alarm is present and cannot be cleared.

Expected Behavior
------------------
No alarm should be present.

Actual Behavior
----------------
Unexpected alarm raised that cannot be cleared.

Reproducibility
---------------
Reproducible.

System Configuration
--------------------
Any Debian-based StarlingX environment with PTP configured.

Branch/Pull Time/Commit
-----------------------
r/stx7.0.

Last Pass
---------
The issue doesn't happen with CentOS-based installations; also not seen in Debian-based environments before June 17th.

Timestamp/Logs
--------------
N/A.

Test Activity
-------------
Feature Testing.

Workaround
----------
Alarm can be deleted using FM, but is raised again after lock/unlock.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/monitoring/+/847835

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/monitoring/+/847835
Committed: https://opendev.org/starlingx/monitoring/commit/237b3856f24f3fe53a24c64574561ae8d053dae8
Submitter: "Zuul (22348)"
Branch: master

commit 237b3856f24f3fe53a24c64574561ae8d053dae8
Author: Douglas Henrique Koerich <email address hidden>
Date: Mon Jun 27 13:31:50 2022 -0300

    Ignore host-based PTP instance in collectd

    The "host_based" PTP instance was introduced in the r/stx6.0 release for
    backward compatibility with legacy PTP configuration, which was
    deprecated later on. Thus, it makes no sense anymore to look at
    host-scoped PTP configuration files for sources of alarms, since they
    are now associated to one of many PTP instances.
    This change does the following:
    a) Reverts the logic introduced by
    https://review.opendev.org/c/starlingx/monitoring/+/845172 that managed
    the location of host-scoped PTP configuration file. That change caused
    the bug by making the /etc/linuxptp/ptp4l.conf file visible with default
    (but invalid) contents;
    b) Removes every handle of "host_based" instance from code.

    Tests:
    PASS: In a Debian-based environment configured with PTP instances,
          checked that no "host_based" alarm is triggered.

    Closes-Bug: 1979892
    Signed-off-by: Douglas Henrique Koerich <email address hidden>
    Change-Id: I96daf8bad746f0ec029d4a59051b4196ea8dba57