Backup & Restore: Ansible restore playbook fails in Restore armada manifests task -Armada folder was not restored

[Thiago Paiva Brito]

*+Brief Description+*

Fail trying to run the restore playbook.

*+Severity+*

<Critical: System/Feature is not usable after the defect>

*+Steps to Reproduce+*
 * Install a simplex system with StarlingX master
 * Run the Backup Ansible playbook from controller-0
 * Install a clean image of StarlingX in the system with wipedisk=false
 * Run the restore Ansible playbook locally with the backup file saved above

*+Expected Behavior+*

Run the ansible restore playbook and unlock the controller successfully.

*+Actual Behavior+*

The execution of the ansible restore playbook fails.

*+Reproducibility+*

Reporducible

*+System Configuration+*

SX IPv4

*+Timestamp/Logs+*

*ansible.log issue:*
{code:java}
2022-06-21 14:24:51,897 p=11492 u=sysadmin |  Tuesday 21 June 2022  14:24:51 +0000 (0:00:12.260)       0:28:24.793 **********
2022-06-21 14:25:04,032 p=11492 u=sysadmin |  failed: [localhost] (item=opt/platform/armada/) => changed=true
  cmd:
  - tar
  - -C
  - /
  - --overwrite
  - -xpf
  - /scratch/localhost_platform_backup_2022_06_21_13_11_49.tgz
  - opt/platform/armada/
  delta: '0:00:11.965780'
  end: '2022-06-21 14:25:03.999967'
  item: opt/platform/armada/
  msg: non-zero return code
  rc: 2
  start: '2022-06-21 14:24:52.034187'
  stderr: |-
    tar: opt/platform/armada: Not found in archive
    tar: Exiting with failure status due to previous errors
  stderr_lines:
  - 'tar: opt/platform/armada: Not found in archive'
  - 'tar: Exiting with failure status due to previous errors'
  stdout: ''
  stdout_lines: <omitted>
2022-06-21 14:25:04,033 p=11492 u=sysadmin |  PLAY RECAP ********************************************************************************************************************************************************************************************************
2022-06-21 14:25:04,033 p=11492 u=sysadmin |  localhost                  : ok=481  changed=269  unreachable=0    failed=1
2022-06-21 14:25:04,033 p=11492 u=sysadmin |  Tuesday 21 June 2022  14:25:04 +0000 (0:00:12.136)       0:28:36.930 ********** {code}
Armada folder is missed or not restored.
{code:java}
controller-0:~$ ls /opt/platform/
config  device_images  extra  helm_charts  keystone  lost+found  puppet  sysinv
 {code}
*+Alarms+*
{code:java}
[sysadmin@controller-0 ~(keystone_admin)]$ fm alarm-list
+----------+---------------------------------------------------------------------+-------------------+----------+---------------------+
| Alarm ID | Reason Text                                                         | Entity ID         | Severity | Time Stamp          |
+----------+---------------------------------------------------------------------+-------------------+----------+---------------------+
| 200.001  | controller-0 was administratively locked to take it out-of-service. | host=controller-0 | warning  | 2022-06-21T14:17:41 |
|          |                                                                     |                   |          | .556522             |
|          |                                                                     |                   |          |                     |
+----------+---------------------------------------------------------------------+-------------------+----------+---------------------+ {code}

*+Test Activity+*

Regression Testing

*+Workaround+*

Manually edit the playbook to remove the restore condition

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/847076

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/847076
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/a7ce75e12ccb50eb7c03f3088244ef5af13eea16
Submitter: "Zuul (22348)"
Branch: master

commit a7ce75e12ccb50eb7c03f3088244ef5af13eea16
Author: Thiago Brito <email address hidden>
Date: Tue Jun 21 14:55:19 2022 -0300

    Fix B&R with no armada apps installed

    [1] introduced an error when backing up an instance of the system that
    doesn't contain any armada app on it. This commit changes the condition
    on which to restore the armada and fluxcd folders to "always restore if
    it is on the backup archive".

    TEST PLAN
    PASS Backup & Restore stx.7.0 with fluxcd apps only

    [1] https://review.opendev.org/c/starlingx/ansible-playbooks/+/846244

    Closes-Bug: 1979353
    Signed-off-by: Thiago Brito <email address hidden>
    Change-Id: I45d9992f3e9380c258cf85f78fb3d7ebd2c17eb9