ice driver loads COMMS DDP FW by default

[Jim Somerville]

Brief Description
-----------------
The ice driver loads COMMS DDP firmware by default. This is not what most users expect, it should be the "OS default" aka regular DDP firmware that loads by default. This can cause problems with DPDK if the version isn't ready for it. One customer has seen GTP fail using the COMMS firmware.

Both DDP firmwares should be available but the COMMS version should not load by default.

Severity
--------
Minor

Steps to Reproduce
------------------
Boot with Intel ICE network card available

Expected Behavior
------------------
"OS default" DDP firmware loads by default when the ice driver starts up. This firmware is supplied by the ice driver.

Actual Behavior
----------------
DDP COMMS firmware loads

Reproducibility
---------------
100%

System Configuration
--------------------
Doesn't matter, you just need an Intel ICE network card

Workaround
----------
Manually change the stx-ice.pkg symlink to point to the DDP FW that you want to load. Then reboot.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/kernel/+/846181

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/kernel/+/846181
Committed: https://opendev.org/starlingx/kernel/commit/d9bb55fd5d41c7f7c897dd731d371735cc293786
Submitter: "Zuul (22348)"
Branch: master

commit d9bb55fd5d41c7f7c897dd731d371735cc293786
Author: Jim Somerville <email address hidden>
Date: Thu Jun 2 13:35:23 2022 -0400

    kmod-ice: Restore OS default DDP firmware

    Problem:
    Apparently there was some confusion about adding the
    ICE COMMS DDP FW, we wanted to include it for
    testing purposes, but did not really want it to be
    the default loaded upon bootup. This causes grief to
    at least two versions of DPDK, namely 20.11 and 21.11
    when using GPRS Tunneling Protocol (GTP).

    Solution:
    Restore the OS default DDP FW version which
    ships with the ice driver, and make it load by
    default at bootup. We also continue to leave the
    COMMS version in the package so it can be tried if desired.

    Verification:
    - Boot up on server that contains ice network hardware
    - Confirm that ice nework interfaces are working
    - Check that the stx-ice.pkg symlink points to the OS default
    DDP firmware and not the COMMS version
    - run "dmesg | grep -i DDP" and confirm that the driver loaded
    the OS default DDP firmware and not the COMMS version

    Partial-Bug: 1978883

    Fixes: a3e3f7e ("Ice Driver: use new comms ddp firmware")
    Change-Id: I14758dc49f5740b8f5482143f4dfd49febff2234
    Signed-off-by: Jim Somerville <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/kernel/+/846434

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/kernel/+/846434
Committed: https://opendev.org/starlingx/kernel/commit/199198fc97e2d5e5f0928cb3c1433e99dfa7437c
Submitter: "Zuul (22348)"
Branch: master

commit 199198fc97e2d5e5f0928cb3c1433e99dfa7437c
Author: Jim Somerville <email address hidden>
Date: Fri Jun 17 13:07:53 2022 -0400

    Debian: ice: Restore OS default DDP firmware

    Port commit d9bb55fd5d41c7f7c897dd731d371735cc293786
    to debian, its review is at:
    https://review.opendev.org/c/starlingx/kernel/+/846181

    Straightforward, nothing needed any major change.

    Verification:
    - both ice-common and ice packages build successfully
    - ice-common now contains both the regular ddp firmware
    and the comms ddp firware
    - stx-ice.pkg symlink now points at the regular ddp fw

    Closes-Bug: 1978883

    Change-Id: I946a6447a70628a3e9f5f967e5c496849582ce71
    Signed-off-by: Jim Somerville <email address hidden>