Backup and Restore: Coredump.conf not being restored

[Hugo Nicodemos Brito]

Brief Description
-----------------
The coredump.conf system file was not restored with the configurations that were done through the service parameters table before the backup. So, the coredump.conf and the table don't match after B&R process.

Severity
--------
<Minor: System/Feature is usable with minor issue>

Steps to Reproduce
------------------
1) Configure coredump parameters through service parameter table before backup:

system service-parameter-add platform coredump process_size_max=2.1G
system service-parameter-add platform coredump external_size_max=2.2G
system service-parameter-add platform coredump max_use=200M
system service-parameter-add platform coredump keep_free=1.1G
2) run the B&R

3) Check the service parameters table and the file /etc/systemd/coredump.conf.d/coredump.conf after restore.

Expected Behavior
------------------
The coredump.conf file configured before backup must be equal to the coredump.conf file after restore. Also, the coredump.conf file must match with the coredump parameters configured in the service parameters table. Otherwise, the coredump.conf must have the default values.

Actual Behavior
----------------
coredump.conf file configured before backup doesn't match with coredump.conf file after restore.

Reproducibility
---------------
100% Reproducible

System Configuration
--------------------
<One node system, Two node system, Multi-node system, Dedicated storage, https, IPv4, IPv6 etc.>

Branch/Pull Time/Commit
-----------------------
Master

Workaround
----------
Update the service parameters table after restore:

system service-parameter-update platform coredump <parameter>=<value>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/845762

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/845762
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/1ed375a0446bfc39efe2e88ecf3e422e486003ff
Submitter: "Zuul (22348)"
Branch: master

commit 1ed375a0446bfc39efe2e88ecf3e422e486003ff
Author: Hugo Brito <email address hidden>
Date: Tue Jun 14 11:11:13 2022 -0300

    B&R: Restore coredump.conf.d directory

    The coredump.conf system file was not restored with the configurations
    that were done through the service parameters table before the backup.
    This overrides all the content of coredump configuration directory
    during the restore process.

    Test Plan:
    - Modify coredump service parameter prior to taking platform backup:
    system service-parameter-add platform coredump <parameter>=<value>
    - Verify that coredump.conf file is updated accordingly.
    - Perform platform backup and restore.
    - Verify that both coredump service parameter and coredump.conf file
    were restored with the last configured value.
    PASS: B&R playbooks ran without errors (AIO-SX and AIO-DX).

    Closes-bug: 1978611

    Signed-off-by: Hugo Brito <email address hidden>
    Change-Id: I2d268b92beaccc31e595ab3b36e7414fc45abcbc