OOT alarm not raised for PHC drift in ptp4l-only scenario

[Douglas Henrique Koerich]

Brief Description
-----------------
"Out-of-toleration" alarm not set for PTP when PHC clock exceeds the thresholds, when that happens in a scenario where only ptp4l instance (no ts2phc) is running.

Severity
--------
Major

Steps to Reproduce
------------------
1. Configure ptp4l and phc2sys instances;
2. After PTP locked to foreign GM clock, manually adjust PHC clock by means of phc_ctl tool to value exceeding the threshold (1000);
3. Look for OOT alarm and check is not found.

Expected Behavior
------------------
An OOT alarm should be visible.

Actual Behavior
----------------
No actual OOT alarm seen.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Any system connected to foreign GM clock but not SyncE-based.

Branch/Pull Time/Commit
-----------------------
master

Last Pass
---------
First time this test is performed.

Timestamp/Logs
--------------
From /var/log/collectd.log, no logs for OOT alarm found:
2022-06-13T22:12:00.343 controller-0 collectd[903704]: info instance name ptpinstance1 type ptp4l
2022-06-13T22:12:00.361 controller-0 collectd[903704]: info ptp plugin PTP service <email address hidden> admin state:enabled
2022-06-13T22:12:00.374 controller-0 collectd[903704]: info ptp plugin PTP service <email address hidden> active state:active
2022-06-13T22:12:00.374 controller-0 collectd[903704]: info Calling check_ptp_regular for instance ptpinstance1
2022-06-13T22:12:00.597 controller-0 collectd[903704]: info check_ptp_regular: master_offset is 15.0

Test Activity
-------------
Developer Testing

Workaround
----------
N/A

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/monitoring/+/845645

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/monitoring/+/845645
Committed: https://opendev.org/starlingx/monitoring/commit/faa4bad91b7bc911f0f5c959906190964a51d48e
Submitter: "Zuul (22348)"
Branch: master

commit faa4bad91b7bc911f0f5c959906190964a51d48e
Author: Douglas Henrique Koerich <email address hidden>
Date: Mon Jun 13 19:39:21 2022 -0300

    Check time drift also when sampling with GM

    PHC device clock must be checked against time drifts and generate the
    proper alarm whenever minor or major thresholds are exceeded. Currently
    that check is performed only for PTP instances collecting samples using
    GNSS (when a ts2phc instance is running), but not for those using
    external GM (with ptp4l instance only), which may lead them to having
    the alarm not set. This change performs time drift checking also in the
    latter condition.

    Test Plan:
    PASS: In a lab with locked PTP, forcedly adjust PHC clock to exceed
          threshold and check for alarm raising.

    Closes-Bug: 1978495
    Signed-off-by: Douglas Henrique Koerich <email address hidden>
    Change-Id: Iea9a7b02336c997bb8fcd2692d77395ab9df765a