Debian: Login banner is incorrect

[Leonardo Fagundes Luz Serrano]

Brief Description

When logging into an ssh session for a controller running a Debian ISO the ssh banner is incorrectly displaying the unauthorized access warning twice but also displaying "-sh: The: command not found"

Severity

Minor - but this looks unprofessional for the 1st release of Debian

Steps to Reproduce

ssh sysadmin@{controller-0 IP addr}

Expected Behavior

Login banner should look like this:

sysadmin@128.224.150.84's password:
Last login: Wed Jun 8 17:18:29 2022 from 128.224.72.70
/etc/motd.d/00-header:

WARNING: Unauthorized access to this system is forbidden and will be
prosecuted by law. By accessing this system, you agree that your
actions may be monitored if unauthorized usage is suspected.

/etc/motd.d/10-system:

====================================================================
         SYSTEM: yow-cgcs-supermicro-5-6
====================================================================
Actual Behavior

Login banner instead looks like this:

sysadmin@128.224.48.20's password:
====================================================================
         SYSTEM: yow2-r740-011
====================================================================
Linux controller-0 5.10.0-6-rt-amd64 #1 SMP PREEMPT_RT Debian 5.10.112-1.stx.15 (2022-06-05) x86_64

WARNING: Unauthorized access to this system is forbidden and will be
prosecuted by law. By accessing this system, you agree that your
actions may be monitored if unauthorized usage is suspected.

Last login: Thu Jun 9 02:35:22 2022

WARNING: Unauthorized access to this system is forbidden and will be
prosecuted by law. By accessing this system, you agree that your
actions may be monitored if unauthorized usage is suspected.

-sh: The: command not found
-sh: The: command not found
In particular notice:

The WARNING is displayed twice but should only be shown once
the -sh: The: command not found should not be displayed at all
Reproducibility

Reproducible

System Configuration

AIO-SX

Load info (eg: 2022-03-10_20-00-07)

June 7 build

Last Pass

Unsure, but this issue was not occurring earlier in the 22.06 release.

Timestamp/Logs

n/a

Alarms

n/a

Test Activity

Sanity

Workaround

n/a

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/845616

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/845616
Committed: https://opendev.org/starlingx/stx-puppet/commit/c5697da57d8068a5aff9bf2fe9261ad78b8e46c6
Submitter: "Zuul (22348)"
Branch: master

commit c5697da57d8068a5aff9bf2fe9261ad78b8e46c6
Author: Leonardo Fagundes Luz Serrano <email address hidden>
Date: Mon Jun 13 14:55:40 2022 -0300

    Debian: Fixed banner error message

    When logging, a message would show saying
    "-sh: The: command not found"

    This was due to a warning message that was being added
    to /etc/bash_completion.d/openstack when the command
    "openstack complete" is executed to fill the file.

    Added a "-q" flag to suppress the warning message.

    Test Plan:
    PASS normal banner when logging
    PASS file does not contain the warning message
    PASS bootstrap and unlock

    Closes-Bug: 1978493

    Signed-off-by: Leonardo Fagundes Luz Serrano <email address hidden>
    Change-Id: Ie935ae2c32e644cd6bc622046319adfb90d6477e