Change the name of package_checksums file to <software_version>_packages_list.txt

[Shrikumar Sharma]

Brief Description

The name of the packages list file for prestaging should be <version>_packages_list.txt. It is currently packages_list.

Severity

<Minor: System/Feature is usable with minor issue>

This does not affect current upgrades from 21.12 to 22.06.

Steps to Reproduce

Install the system from bootimage.iso. Check the filename at /usr/local/share/pkg-list.

Expected Behavior

The file name should be <version>_packages_list.txt

Actual Behavior

File name is packages_list.

Reproducibility

<Reproducible/Intermittent/Seen once>

100%

System Configuration

DC

Load info (eg: 2022-03-10_20-00-07)

22.06

Last Pass

N/A.

Timestamp/Logs

Alarms

Test Activity

Developer Testing

Workaround

Rename the files as root

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/metal/+/845509

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/845510

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/metal/+/845509
Committed: https://opendev.org/starlingx/metal/commit/f31cd0b255d805a50bde1cdfc8d3e27bd9132b9e
Submitter: "Zuul (22348)"
Branch: master

commit f31cd0b255d805a50bde1cdfc8d3e27bd9132b9e
Author: Shrikumar Sharma <email address hidden>
Date: Sun Jun 12 18:39:36 2022 -0400

    Copying the package_checksums file to
    <platform_release>_packages_list.txt

    The prestaging operation on the system controller requires the list
    of packages and their checksums in a file named
    "<platform_release>_packages_list.txt", where <software_version> is
    the version of the system controller (i.e. the new version which the
    subclouds are being upgraded to).

    The list of packages and their checksums is obtained from different
    sources as a file named "package_checksums". This file should be
    copied to /usr/local/share/pkg-list as
    <platform_release>_packages_list.txt. It is currently copied as
    package_checksums.

    This fix copies the file "package_checksums" to
    /usr/local/share/pkg-list as <platform_release>_packages_list.txt.

    Test Plan:

    PASS: Verify that package_checksums is copied to
          /usr/local/share/pkg-list as <platform_release>_packages_list.txt
          when upgrading the system controller to a higher version.

    PASS: Verify that package_checksums is copied to
          /usr/local/share/pkg-list as <platform_release>_packages_list.txt
          when installing a controller over pxeboot

    PASS: Verify that package_checksums is copied to
          /usr/local/share/pkg-list as <platform_release>_packages_list.txt
          when adding a subcloud from the system controller (using dcmanager
          add)

    PASS: Verify that package_checksums is copied to
          /usr/local/share/pkg-list as <platform_release>_packages_list.txt
          when installing a system controller in virtualbox from
          bootimage.iso.

    Closes-Bug: 1978420
    Signed-off-by: Shrikumar Sharma <email address hidden>
    Change-Id: I6270a7c9169718b2096a83135eeadb634d37b76b

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/845510
Committed: https://opendev.org/starlingx/distcloud/commit/b7644619d5ecdb8c23ec665e11312a667f5fea30
Submitter: "Zuul (22348)"
Branch: master

commit b7644619d5ecdb8c23ec665e11312a667f5fea30
Author: Shrikumar Sharma <email address hidden>
Date: Sun Jun 12 19:10:41 2022 -0400

    Copy package_checksums to <software_version>_packages_list.txt

    The prestaging operation on the system controller requires the list
    of packages and their checksums in a file named
    "<software_version>_packages_list.txt", where <software_version> is
    the version of the system controller (i.e. the new version which the
    subclouds are being upgraded to).

    Currently, the file is stored as package_checksums. This causes
    the prestaging operation to fail.

    This fix ensures that the list of packages and checksums is stored
    correctly as <software_version>_packages_list.txt at
    /usr/local/share/pkg-list when a subcloud is installed. The file
    will then be available for future prestaging operations with the
    right name.

    Test Plan:

    PASS: Verify that prestaging of packages for upgrade is successfully
          executed.

    PASS: Verify that the file is correctly stored as
          <software_version>_packages_list.txt at
          /usr/local/share/pkg-list when adding a subcloud.

    PASS: Verify that package_checksums is copied to
          /usr/local/share/pkg-list as <software_version>_packages_list.txt
          when upgrading the system controller to a higher version.

    PASS: Verify that package_checksums is copied to
          /usr/local/share/pkg-list as <software_version>_packages_list.txt
          when installing a controller over pxeboot

    PASS: Verify that package_checksums is copied to
          /usr/local/share/pkg-list as <software_version>_packages_list.txt
          when adding a subcloud from the system controller (using dcmanager
          add)

    PASS: Verify that package_checksums is copied to
          /usr/local/share/pkg-list as <software_version>_packages_list.txt
          when installing a system controller in virtualbox from
          bootimage.iso.

    Closes-Bug: 1978420
    Depends-On: https://review.opendev.org/c/starlingx/metal/+/845509

    Signed-off-by: Shrikumar Sharma <email address hidden>
    Change-Id: I1018d79cb91cc3af767fa8b244be180fed70b9a7