config: ttys_dcd periodically performs synchronous polling

[Iago Filipe]

Brief Description

The ttys_dcd (serial console data detect) feature enable/disable currently depends on synchronous polling via the conductor of the sysinv db config

Severity

Minor: System/Feature is usable with minor issue. Though could lead to scalability issues with larger number of workers.

Steps to Reproduce

ttys_dcd polling is performed periodically within sysinv-agent.

Expected Behavior

In order to support better scaling and config management, the config should be driven by puppet.

Actual Behavior

Polling and synchronous api requests into conductor.

Reproducibility

Reproducible.

System Configuration

All systems

Load info

Day one behaviour.

Last Pass

Did this test scenario pass previously? If so, please indicate the load/pull time info of the last pass.

Use this section to also indicate if this is a new test scenario.

Timestamp/Logs

Enabled sysinv debug logs and check sysinv.log in a running system for periodic ttys_dcd updates. Additional instrumentation is required in _update_ttys_dcd_status() to see the updates.

Alarms

N/A

Test Activity

Evaluation

Workaround

N/A. Day One behaviour however, should be converted to puppet driven config to enable future scalability and alignment with config management.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/845174

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/845175

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/845174
Committed: https://opendev.org/starlingx/stx-puppet/commit/5c64fa4487b19356be4fb286278df0a61240eb68
Submitter: "Zuul (22348)"
Branch: master

commit 5c64fa4487b19356be4fb286278df0a61240eb68
Author: Iago Estrela <email address hidden>
Date: Wed Jun 8 17:50:54 2022 -0300

    Add serial console configuration manifest

    Drive serial console configuration via puppet manifest. Hieradata
    will be provided when [1] were introduced, which is passing the
    serial console configuration from the hands of the sysinv agent to
    this puppet manifest + platform plugin.

    [1] https://review.opendev.org/c/starlingx/config/+/845175

    Closes-Bug: 1978009

    Test plan:
    PASS: Bootstrap AIO-SX, host unlock and verify alarms.
    PASS: Set host ttys_dcd attribute and check serial console.
    PASS: Unset host ttys_dcd host attribute and check serial console.

    Signed-off-by: Iago Estrela <email address hidden>
    Change-Id: Ie6d5f595a00d75a8d5bd43b2195cebf4e67b70cc

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/845175
Committed: https://opendev.org/starlingx/config/commit/28f72983dee14cb6756f936a0a93a82d4024e67e
Submitter: "Zuul (22348)"
Branch: master

commit 28f72983dee14cb6756f936a0a93a82d4024e67e
Author: Iago Estrela <email address hidden>
Date: Wed Jun 8 17:29:00 2022 -0300

    Move ttys_dcd configuration from agent to puppet runtime manifest

    The ttys_dcd flag is currently being configured by sysinv agent audit.
    The API updates the database but it is not instantly configured, it
    must wait for an audit iteration. This change modifies this behavior
    by running a puppet runtime manifest [1] from the API.

    [1] https://review.opendev.org/c/starlingx/stx-puppet/+/845174

    Closes-Bug: 1978009
    Depends-On: https://review.opendev.org/c/starlingx/stx-puppet/+/845174

    Test plan:
    PASS: Bootstrap AIO-SX, host unlock and verify system alarms.
    PASS: Set the flag via host-update and check if the serial console
          was really configured.
    PASS: Unset the flag and also verify serial console.

    Signed-off-by: Iago Estrela <email address hidden>
    Change-Id: Ia3ef2a5e96905c3cd770601d1e78af368bf54a95