Prestage iso installation fails on existing installation when /opt/platform-backup partition size greater than 30GB

[Shrikumar Sharma]

Brief Description

Local Installation overwrite fails over existing installation with /opt/platform-backup/ size greater than 30G.

Severity

Critical

Force parameter doesnt work when the installation to be overwritten has platform-backup partition greater than the default value (30G)

Steps to Reproduce

have a subcloud with valid installation , with platform-backup partition size greater than 30G
generate prestaged.iso with force-install parameter
boot subcloud from prestaged.iso
Expected Behavior

The installation from prestaged.iso should overwrite the existing installation, independently of the previous configuration we have in the previous installation.

Actual Behavior

The installation overwrite fails while trying to run:

parted -s /dev/<disk>

Reproducibility

100% reproducible

System Configuration

DC labs - subclouds

Load info (eg: 2022-03-10_20-00-07)

22.06 - 2022-05-04_20-00-06

Last Pass

new test scenario.

Timestamp/Logs
n/a

Test Activity

Feature Testing

Workaround

parted -s /dev/nmve0n1 rm 1

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/metal/+/845065
Committed: https://opendev.org/starlingx/metal/commit/f1694be26d604292f15f126a6088b53bb7908f9b
Submitter: "Zuul (22348)"
Branch: master

commit f1694be26d604292f15f126a6088b53bb7908f9b
Author: Shrikumar Sharma <email address hidden>
Date: Tue Jun 7 20:37:05 2022 -0400

    Delete Platform Backup partition first when installing Prestage iso

    The size of a subcloud's platform backup partition can be increased
    from a minimum of 30GB using a persistent_size entry in the file
    install_values.yaml.

    However, a failure to install prestage.iso is observed when a subcloud
    has a platform backup partition size greater than 30GB. The failure to
    install the prestage iso occurs, because "parted" attempts, by default
    to create a 30GB platform backup partition in the prestaging kickstart.
    "parted" fails when it encounters a partition size greater than 30GB.

    This fix addresses this issue by always deleting the partition before
    prestaging. This allows parted to create the partition with the default
    value of 30GB, irrespective of what existed there previously.

    Test Plan:
    PASS: Verify that prestage ISO installation succeeds when the
          partition size of Platform Backup is greater than 30GB.

    Regression:
    PASS: Verify that prestage ISO installation succeeds when the
          force-install option is provided to gen_prestage_iso.sh

    PASS: Verify that prestage ISO installation succeeds when the
          force-install option is not provided to gen_prestage_iso.sh
          and there is no pre-existing installation on the subcloud.

    PASS: Verify that prestage ISO installation fails when the
          force-install option is not provided to gen_prestage_iso.sh
          and there is a pre-existing installation on the subcloud.

    Closes-Bug: 1977975

    Change-Id: I34fbf7bc6fb550deaee26e5c9a71402611834aa8
    Signed-off-by: Shrikumar Sharma <email address hidden>