FluxCD: Apps cannot be reapplied if http port is updated
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Fix Released
|
Medium
|
Thiago Paiva Brito |
Bug Description
Brief Description
-----------------
For the FluxCD apps, the helmrepository defined on the fluxcd-manifests folder is only changed at upload time. If we change the port at run-time, the app loses the ability to download new charts since the helmrepository will still be configured to the old port.
Severity
--------
Major: System/Feature is usable but degraded
Steps to Reproduce
------------------
system service-
Apply app that was uploaded before OR remove/apply an app that was already applied
Expected Behavior
------------------
App fwk downloads the charts and app installs in any case
Actual Behavior
----------------
- If app is uploaded and not applied: App fwk fails to download the charts from the helmrepository
- If app was already applied: App can be reapplied but not removed/applied
- "kubectl get helmrepository" -A shows errors for all resources
Reproducibility
---------------
3 out of 3 attempts
System Configuration
-------
All configurations
Branch/Pull Time/Commit
-------
master @ 80f97188 Merge "Fix service_
Last Pass
---------
N/A
Timestamp/Logs
--------------
N/A
Test Activity
-------------
Feature Testing
Workaround
----------
- Revert to port 8080
- Remove and reapply the app
Changed in starlingx: | |
status: | New → In Progress |
Changed in starlingx: | |
importance: | Undecided → Medium |
tags: | added: stx.7.0 stx.apps |
Changed in starlingx: | |
assignee: | nobody → Thiago Paiva Brito (outbrito) |
Reviewed: https:/ /review. opendev. org/c/starlingx /config/ +/844340 /opendev. org/starlingx/ config/ commit/ a9eb21d688ab98f 3446b06681f9c30 cb1bf6d2c3
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit a9eb21d688ab98f 3446b06681f9c30 cb1bf6d2c3
Author: Thiago Brito <email address hidden>
Date: Wed Jun 1 18:08:01 2022 -0300
Fix HelmRepository CRDs on lighttpd port change
This commit fixes the problem of changing the lighttpd port in 2 parts: Operator to change the helmrepository.yaml applied/ reapplied and removed that
- Added a callback to the puppet runtime manifest apply to call a method
that will fix the addres on the custom resource if it is already created
on puppet
- Modified the FluxCDKustumize
when the app is uploaded/
responsibility from kube_app.py.
TEST PLAN tory.yaml was orig.yaml was created
helmrepositor y.yaml was updated and helmrepository- orig.yaml was
PASS change the http port and check if the HelmRepository resource was
updated on kubernetes
PASS check if the resource definition on base/helmreposi
uploaded and that helmrepository-
PASS upload the snmp-app and verify that the default port for it's
created.
Closes-Bug: #1977471
Signed-off-by: Thiago Brito <email address hidden> 89a1774f2c13dba 1f5d16432c5
Change-Id: I4ac50bc7dabdb5