udev is missing some multipath disk/partition fields

[Felipe Sanches Zanoni]

Brief Description
-----------------

The udev subsystem intermittently is not providing correct information about multipath disks (lun and fc) and partitions.

Severity
--------

Minor

Steps to Reproduce
------------------
Using multipath with SAN disks is possible to verify udev information using udevadm info <disk-path>.

Some information about partitions or multipath information may be missing some times.

If some information is missing, a reboot can fix.

Expected Behavior
------------------
Udev should provide correct information about multipath SAN disks.

Actual Behavior
----------------
Udev sometimes has incorrect information about multipath SAN disks.

Reproducibility
---------------
Intermittent
6/10

System Configuration
--------------------
One node system
Two node system
Multi-node system
Dedicated storage

Branch/Pull Time/Commit
-----------------------
N/A

Last Pass
---------
SAN disks multipath is a new feature.

Timestamp/Logs
--------------
No logs

Test Activity
-------------
Developer Testing

Workaround
----------
The workaround is to use disk path to parse information about disk, partitions and use 'multipath -c' commando to verify if the disk is a multipath device.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/844300
Committed: https://opendev.org/starlingx/config/commit/c0eb3fefea0e480a2fd6655a9912341e28fac0d6
Submitter: "Zuul (22348)"
Branch: master

commit c0eb3fefea0e480a2fd6655a9912341e28fac0d6
Author: Felipe Sanches Zanoni <email address hidden>
Date: Wed Jun 1 09:56:27 2022 -0400

    Properly handle multipath disks in the inventory

    Command host-disk-list is listing mpath partitions and
    disks that are part of multipath group.
    It was filtering by udev required field ID_PART_ENTRY_NUMBER,
    but udev is not always giving correct information for mpath devices.
    This fix is necessary to workaround the unexpected behavior.

    Udev issue will be tracked in bug 1976553.

    Related-Bug: #1976553
    Story: 2010046
    Task: 45518

    Test Plan:
    PASS: Standard + Storage, with Ceph, 4 osd (CentOS with multipath)

    Signed-off-by: Felipe Sanches Zanoni <email address hidden>
    Signed-off-by: Jackie Huang <email address hidden>
    Change-Id: I18e6fd44d9d5c79a13ac44ddf3a3d40972c93315

[Ghada Khalil (gkhalil)]

@Felipe, are other fixes expected for this LP? Or can it be marked as Fix Released?

[Felipe Sanches Zanoni (fsanches)]

Hi, @Ghada, this bug was created to investigate why udev is not identifying correctly all information from multipath disks and if this have a fix. Bob asked to do so.

This might be related to udev and kernel drivers.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/872435