stx-puppet creating junk files for logical volumes

[Hugo Nicodemos Brito]

Brief Description
-----------------
In the StarlingX installation, the stx-puppet tries to wipe the start and end of some logical volumes to prevent problems, but the command uses the wrong output file resulting in the creation of junk files with the name of these logical volumes.

Severity
--------
<Minor: System/Feature is usable with minor issue>

Steps to Reproduce
------------------
It occurs on the StarlingX installation.

Expected Behavior
------------------
stx-puppet wipe the start/end of the logical volume.

Actual Behavior
----------------
stx-puppet creates 10MB junk files with the name of logical volumes.

Reproducibility
---------------
<100% Reproducible>

System Configuration
--------------------
<One node system, Two node system, Multi-node system, Dedicated storage, Distributed Cloud, https, IPv4, IPv6 etc.>

Branch/Pull Time/Commit
-----------------------
master

Workaround
----------
Execute the correct command: `dd if=/dev/zero of=${device_path} bs=1M count=10` and delete the files.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/843496

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/843496
Committed: https://opendev.org/starlingx/stx-puppet/commit/d23ad02929f699f1684d45b1ad1706b09c477372
Submitter: "Zuul (22348)"
Branch: master

commit d23ad02929f699f1684d45b1ad1706b09c477372
Author: Hugo Brito <email address hidden>
Date: Thu May 26 13:01:00 2022 -0300

    Fix stale data cleanup on the logical volumes

    The stx-puppet tries to wipe the start and end of some logical
    volumes to prevent problems, but the command uses the wrong output
    file resulting in the creation of junk files.

    Test Plan:
    - Tested on AIO-SX and AIO-DX, the files were not created.

    Closes-bug: 1975851

    Signed-off-by: Hugo Brito <email address hidden>
    Change-Id: I96a39455b7a2611ec53212835198fbf6f2efc11f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/849031

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/849047
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/8774849b6ac62bb7faefa4d17422c4b5ce06eddc
Submitter: "Zuul (22348)"
Branch: master

commit 8774849b6ac62bb7faefa4d17422c4b5ce06eddc
Author: Hugo Brito <email address hidden>
Date: Thu Jul 7 18:47:38 2022 -0300

    B&R: Change the restore staging directory

    The only directory preserved over a Backup and Restore
    should be /opt/platform-backup, this updates the staging
    directory used on the restore.

    Test Plan:
    PASS: Perform backup and restore on CentOS
    PASS: Perform backup and restore on Debian

    Partial-bug: 1975851

    Signed-off-by: Hugo Brito <email address hidden>
    Change-Id: I5db03c9731b5f3c0c05cc8bbd7890b504d3b154a

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/849031
Committed: https://opendev.org/starlingx/stx-puppet/commit/527bb3700f3a400b41628c168cd184eedc04afbc
Submitter: "Zuul (22348)"
Branch: master

commit 527bb3700f3a400b41628c168cd184eedc04afbc
Author: Hugo Brito <email address hidden>
Date: Thu Jul 7 15:14:57 2022 -0300

    Fix stale data cleanup on the logical volumes

    The stx-puppet tries to wipe the start and end of some logical
    volumes to prevent problems, but the command uses the wrong output
    file resulting in the creation of junk files. The command for scratch
    does not work since it's already mounted before the bootstrap. For this
    reason it was decided to unmount the filesystem before wiping the
    device's data.

    Depends-On: https://review.opendev.org/c/starlingx/ansible-playbooks/+/849047

    Test Plan:
    PASS: Perform bootstrap and restore-platform playbooks on centOS
    PASS: Perform bootstrap and restore-platform playbooks on Debian

    Closes-bug: 1975851

    Signed-off-by: Hugo Brito <email address hidden>
    Change-Id: I3d0aa664a1bd72dd49ca2f4941bc06d25517b474