Debian: mlnx-ofed-kernel-modules package includes source files

[Jiping Ma]

Brief Description

The mlnx-ofed-kernel-modules Debian package contains source code files (and more) in "/usr/src/ofa_kernel/x86_64/". Due to this, the Debian initramfs image will contain unnecessary files.

Please note that the Broadcom driver depends on the Mellanox driver's build artifacts, so fixing this issue (i.e., moving the /usr/src/ofa_kernel/ directory to a separate "-devel" package) will require adjusting the Broadcom driver's build dependencies as well.

Severity

Minor: Unnecessary files are included in a kernel module package.

Steps to Reproduce

Build Debian packages with "build-pkgs -p mlnx-ofed-kernel". Inspect the resulting mlnx-ofed-kernel-modules Debian package.

Expected Behavior

The mlnx-ofed-kernel-modules package should only contain kernel modules. The source file should be in a separate "-devel" package.

Actual Behavior

mlnx-ofed-kernel-modules package includes source code and build artifacts. A file listing will be attached to this bug report.

Reproducibility

Reproducible. This is a build issue.

System Configuration

Not applicable.

Load info (eg: 2022-03-10_20-00-07)

Recent Debian-based builds, since the Mellanox OFED driver commits have been merged.

Last Pass

Not applicable; day-1 issue.

Timestamp/Logs

Please see the attached package content listing.

Alarms

Not applicable.

Test Activity

I noticed this issue while working on the Broadcom driver integration for Debian.

Workaround

None.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/kernel/+/844911

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/kernel/+/844911
Committed: https://opendev.org/starlingx/kernel/commit/66e70da1c2076e80cd7ca1fd0020fb51732aae27
Submitter: "Zuul (22348)"
Branch: master

commit 66e70da1c2076e80cd7ca1fd0020fb51732aae27
Author: Jiping Ma <email address hidden>
Date: Wed May 4 22:43:11 2022 -0700

    Debian: mlnx-ofa_kernel adds dev package

    This commit moves source code files "/usr/src/ofa_kernel/x86_64/" from
    modules package to dev package, only left all ko in modules package.
    Also adds postinst, prerm files for dev package and modify postinst,
    prerm files for modules package because source files are moved to
    the dev package.

    Test Plan:
    PASS: Build mlnx-ofa_kernel and bnxt_en success for std and rt.
    PASS: Build debian ISO and boot up with qemu.
    PASS: Install in the lab and boot up success.

    Closes-bug: 1975452

    Signed-off-by: Jiping Ma <email address hidden>
    Change-Id: I8ac2ad7968fd73cbdaa74e3556c7740a49db6a08