Debian downloader fails to fallback to upstream source

[Scott Little]

Brief Description
-----------------
The debian downloader failed because CENGN was unable to supply on file.
The debian downloader should have retired using the upstream URL, but
it didn't even try.

Severity
--------
Critical: builds fail if CENGN is less than 100% healthy.

Steps to Reproduce
------------------
downloader -b -s

Expected Behavior
------------------
All files download

Actual Behavior
----------------
Download of setuptools from CENGN fails. CENGN is looking in that as a seperate bug.
However the downloader should be making a second download attempt from the original
upstream URL. It's failing to do so, which causes downloader to fail.

Reproducibility
---------------
100%

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
Apr 1, 2022

Last Pass
---------
Mar 27, 2022

Timestamp/Logs
--------------
debrepack - INFO - === Package Name: setuptools
debrepack - INFO - === Debian Package Name: setuptools
debrepack - INFO - === Package Version: 52.0.0-4
debrepack - INFO - === Package Path: /localdisk/designer/vagrant/stx-debian/cgcs-root/stx/integ/python/python3-setuptools
debrepack - INFO - validating setuptools_52.0.0-4.dsc
debrepack - INFO - [ Run - "dget -d http://mirror.starlingx.cengn.ca:80/mirror/debian/snapshot.debian.org/archive/debian/20210629T151153Z/pool/main/s/setuptools/setuptools_52.0.0-4.dsc" ]
debrepack - DEBUG - dget: retrieving http://mirror.starlingx.cengn.ca:80/mirror/debian/snapshot.debian.org/archive/debian/20210629T151153Z/pool/main/s/setuptools/setuptools_52.0.0-4.dsc
debrepack - DEBUG - dget: retrieving http://mirror.starlingx.cengn.ca:80/mirror/debian/snapshot.debian.org/archive/debian/20210629T151153Z/pool/main/s/setuptools/setuptools_52.0.0.orig.tar.gz
debrepack - DEBUG - setuptools_52.0.0-4.dsc:
debrepack - DEBUG - Good signature found
debrepack - ERROR - % Total % Received % Xferd Average Speed Time Time Time Current
debrepack - ERROR - Dload Upload Total Spent Left Speed
debrepack - ERROR -
debrepack - ERROR - 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
debrepack - ERROR - 100 2078 100 2078 0 0 86583 0 --:--:-- --:--:-- --:--:-- 86583
debrepack - ERROR - % Total % Received % Xferd Average Speed Time Time Time Current
debrepack - ERROR - Dload Upload Total Spent Left Speed
debrepack - ERROR -
debrepack - ERROR - 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
debrepack - ERROR - 58 2003k 58 1166k 0 0 4858k 0 --:--:-- --:--:-- --:--:-- 4858k
debrepack - ERROR - curl: (56) Recv failure: Connection reset by peer
debrepack - ERROR - dget: curl setuptools_52.0.0.orig.tar.gz http://mirror.starlingx.cengn.ca:80/mirror/debian/snapshot.debian.org/archive/debian/20210629T151153Z/pool/main/s/setuptools/setuptools_52.0.0.orig.tar.gz failed
debrepack - ERROR - skipping setuptools_52.0.0.orig.tar.gz (not present)
debrepack - ERROR - skipping setuptools_52.0.0-4.debian.tar.xz (not present)
debrepack - ERROR - dscverify: setuptools_52.0.0-4.dsc didn't specify any files present locally
debrepack - ERROR - Validation FAILED!!

Test Activity
-------------
Build

Workaround
----------
Manual download of the offending file using wget.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/root/+/836213
Committed: https://opendev.org/starlingx/root/commit/81e5f92b6855e5761d22f937a9cf59ece7c6512b
Submitter: "Zuul (22348)"
Branch: master

commit 81e5f92b6855e5761d22f937a9cf59ece7c6512b
Author: Scott Little <email address hidden>
Date: Fri Apr 1 16:58:00 2022 -0400

    Fix downloader -s cengn-first strategy

    downloader -s fails on setuptools, reason unknown.
    That issue is being tracked separately.

    However the point of the cengn-first strategy is to actually
    try the upstream url if the download from cengn fails.

    This update covers the Sourced download step of the below
    launchpad. The binary download step will be addressed as a
    separate update.

    Partial-Bug: 1967898
    Signed-off-by: Scott Little <email address hidden>
    Change-Id: Ie216dc104022f3247931355e55d89bcbc375c401

[Ghada Khalil (gkhalil)]

Marking as Fix Released based on commit above