Debian: nfv logs report IOError

[Al Bailey]

Brief Description
-----------------
After bootstrapping and unlocking a Debian environment, nfv-vim.log prints the following 3 errors every minute:
2022-03-28T19:01:56.095 controller-0 VIM_Thread[73268] ERROR rest_api.py.273 Caught exception while processing request, error=I/O operation on closed file..
2022-03-28T19:01:56.143 controller-0 VIM_Thread[73268] ERROR rest_api.py.273 Caught exception while processing request, error=I/O operation on closed file..
2022-03-28T19:01:56.357 controller-0 VIM_Thread[73268] ERROR rest_api.py.273 Caught exception while processing request, error=I/O operation on closed file..

Severity
--------
Minor

Steps to Reproduce
------------------
Unlock a Debian AIO-SX and check the nfv-vim.log

Expected Behavior
------------------
Relatively clean logs

Actual Behavior
----------------
An error log (although it doesnt appear to break anything)

Reproducibility
---------------
100%

System Configuration
--------------------
AIO-SX Debian

Branch/Pull Time/Commit
-----------------------
March 28, 2022

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Feature Testing

Workaround
----------
None necessary. the errors are benign

[Al Bailey (albailey1974)]

https://review.opendev.org/c/starlingx/nfv/+/835919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/nfv/+/835919
Committed: https://opendev.org/starlingx/nfv/commit/bb991828c28ae0c71f65198e4d15b8c9014a814b
Submitter: "Zuul (22348)"
Branch: master

commit bb991828c28ae0c71f65198e4d15b8c9014a814b
Author: Al Bailey <email address hidden>
Date: Wed Mar 30 23:47:13 2022 +0000

    Debian: Eliminate nfv IOError logs during api calls

    The underlying file object for sockets is different on
    python2 (Centos) and python3 (Debian).

     The python2 socket._fileobject appears to allow 'flush'
    to be invoked on it while closed.

     The python3 SocketWriter object does not appear to
    permit operations like flush after it has been closed
    and raises the IOError.

    The sequence of calls is the same in both
    environments, but the underlying issue is that a 'done'
    method is being invoked twice for some API calls.

    This change removes an extra call to 'done' by having
    it just log a deprecation debug entry.

    There should be no difference in functionality on either
    environment, and this also stops the error logs on Debian.

    Test Plan:
      Verified there are no errors in nfv logs on Centos.
      Verified there are no errors in nfv logs on Debian.
      Verified the sysinv logs are clean on both platforms
    when invoking these particular nfv api calls.

    Closes-Bug: #1967592
    Signed-off-by: Al Bailey <email address hidden>
    Change-Id: I41233aabbebd8d6162143e01981170e691c7011d