system host-lock controller failed to execute

[Iago Filipe]

Brief Description
-----------------
When host lock controller the following error message is provided: Only 0 storage monitor available. At least 1 unlocked and enabled hosts with monitors are required. Please ensure hosts with monitors are unlocked and enabled.

Severity
--------
Critical

Steps to Reproduce
------------------
system host-lock <controller>

Expected Behavior
------------------
Lock controller.

Actual Behavior
----------------
Fails to lock controller.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Multi-node system

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/835489

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/835489
Committed: https://opendev.org/starlingx/config/commit/93eece12a66abddc0bf503d685e34e7c2d118182
Submitter: "Zuul (22348)"
Branch: master

commit 93eece12a66abddc0bf503d685e34e7c2d118182
Author: Iago Estrela <email address hidden>
Date: Mon Mar 28 16:42:03 2022 -0300

    Fix system host-lock controller

    With https://review.opendev.org/c/starlingx/config/+/833468
    changes, host-lock controller started to fail. It should also
    check if the host is included in the active monitors list as
    it was prior to 833468 change.

    PASS: Host lock successfully.
    PASS: Host force lock successfully.

    Closes-Bug: 1966809
    Closes-Bug: 1965945

    Signed-off-by: Iago Estrela <email address hidden>
    Change-Id: I25ffbb676481eaf0c126d3691249f725ff880f36

[Ghada Khalil (gkhalil)]

Screening: stx.7.0 / critical - issue introduced due to recent code changes and prevent a basic operation (host lock)