Host is not force lockable when active ceph monitors < required ceph monitors

Bug #1965945 reported by Iago Filipe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
Iago Filipe

Bug Description

Brief Description
-----------------
system host-lock --force semantic check needs to be updated in order to take into account whether is safe to lock hosts based on ceph monitors states.

Severity
--------
Minor

Steps to Reproduce
------------------
1. Active ceph monitors less than required monitors
2. system host-lock --force <stand-by controller/compute>

Expected Behavior
------------------
The force flag should lock the host if there is at least 1 active monitor left (and it's not the current locking host).

Actual Behavior
----------------
Force flag has no effect.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Multi-node system

Iago Filipe (ifest1)
summary: - Host is not force lockable with 1 ceph mon remaining
+ Host is not force lockable when active ceph monitors < required ceph
+ monitors
Changed in starlingx:
assignee: nobody → Iago Filipe (ifest1)
Changed in starlingx:
status: New → In Progress
Ghada Khalil (gkhalil)
tags: added: stx.storage
Changed in starlingx:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.opendev.org/c/starlingx/config/+/833468
Committed: https://opendev.org/starlingx/config/commit/950721eb48706d409db8d3bbb3899f7fb55fdf9a
Submitter: "Zuul (22348)"
Branch: master

commit 950721eb48706d409db8d3bbb3899f7fb55fdf9a
Author: Iago Estrela <email address hidden>
Date: Fri Mar 11 18:16:10 2022 -0300

    Update host force lock semantic check for ceph monitors

    Host lock force flag is not taken into account in the
    host semantic check for ceph monitors available. We want
    to lock the host regardless the system has only one ceph
    monitor available or not.

    Test plan:
    PASS: Fail normal lock controller with 1 remaining monitor.
    PASS: Successfully force lock controller with 1 remaining monitor.
    PASS: System host-delete with 1 remaining monitor.

    Closes-Bug: 1965945

    Signed-off-by: Iago Estrela <email address hidden>
    Change-Id: Ib7b8fdda6cddc4316fbd4b4adb897ca73b1eb846

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
tags: added: stx.7.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/starlingx/config/+/835489
Committed: https://opendev.org/starlingx/config/commit/93eece12a66abddc0bf503d685e34e7c2d118182
Submitter: "Zuul (22348)"
Branch: master

commit 93eece12a66abddc0bf503d685e34e7c2d118182
Author: Iago Estrela <email address hidden>
Date: Mon Mar 28 16:42:03 2022 -0300

    Fix system host-lock controller

    With https://review.opendev.org/c/starlingx/config/+/833468
    changes, host-lock controller started to fail. It should also
    check if the host is included in the active monitors list as
    it was prior to 833468 change.

    PASS: Host lock successfully.
    PASS: Host force lock successfully.

    Closes-Bug: 1966809
    Closes-Bug: 1965945

    Signed-off-by: Iago Estrela <email address hidden>
    Change-Id: I25ffbb676481eaf0c126d3691249f725ff880f36

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.