vswitch service is enabled by default if sysinv fails to provide the related hieradata

[Iago Filipe]

Brief Description
-----------------
During patch apply with https://opendev.org/starlingx/config/commit/4f1533eb441ee8401206c84474dbeb63fc47da04 the vswitch manifest may not get the enabled parameter hieradata from the plugin.

Severity
--------
Critical

Steps to Reproduce
------------------
Reboot required patch apply with: https://opendev.org/starlingx/config/commit/4f1533eb441ee8401206c84474dbeb63fc47da04
https://opendev.org/starlingx/stx-puppet/commit/ae635b5b80fcb61c429a6fc17961a9f3bf614964
https://opendev.org/starlingx/stx-puppet/commit/e00edd94f32f09f07e45b0ee3752d097d3a8f844

Expected behavior
------------------
After patch apply vswitch is disabled by default.

Actual Behavior
----------------
Vswitch is enabled by default in the absence of plugin hieradata.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Multi-node system

Workaround
----------
Change enabled parameter from true to false on vswitch.pp and apply the patch.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/833936
Committed: https://opendev.org/starlingx/stx-puppet/commit/531962bccbae05a7d548438aa8600cf3e6fff6b7
Submitter: "Zuul (22348)"
Branch: master

commit 531962bccbae05a7d548438aa8600cf3e6fff6b7
Author: Iago Estrela <email address hidden>
Date: Tue Mar 15 19:56:41 2022 -0300

    Fix vswitch manifest enabled parameter default value

    Since vswitch is not a required service for the platform
    we can disable it by default. This prevents the dependency
    of the manifest on the OVS plugin hieradata, which may provide
    outdated data during patch apply.

    Test plan:
    PASS: Host lock and unlock with enabled default to undef.
    PASS: Bootstrap with enabled default to undef.
    PASS: Bootstrap with vswitch_type=none.
    PASS: Bootstrap with vswitch_type=ovs-dpdk.

    Closes-Bug: 1965143

    Signed-off-by: Iago Estrela <email address hidden>
    Change-Id: Ia07877d2188b681dfcf9c2700222c1cc7f73f7e6