Prestage Orchestration for reinstall - Error when you dont provide an image-list

[Kyle MacLeod]

Brief Description
-----------------

Prestage Orchestration for reinstall - Error when you dont provide an image-list

Severity
--------

<Major: System/Feature is usable but degraded>

Steps to Reproduce
------------------

ensure you dont have an image-list under /opt/platform/deploy/<rel> on system controller

Expected Behavior
-----------------

you should be able to prestage a subcloud for reinstall without an image-list

Actual Behavior
---------------

you have an error when you dont provide an image list

Reproducibility
---------------

issue is 100% reproducible

System Configuration
--------------------

DC

Branch/Pull Time/Commit
-----------------------

21.12 + TCPG815.patch with commits merged on March, 3thrd

Last Pass
---------

New test scenario.

Timestamp/Logs
--------------

State: prestaging-images, Subcloud: subcloud8: AttributeError: 'NoneType' object has no attribute 'startswith'

Test Activity
-------------

Feature Testing

Workaround
----------
none

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/833219

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/833219
Committed: https://opendev.org/starlingx/distcloud/commit/e101cc165150ab075ef945ae88dbc61fc7b0a8a7
Submitter: "Zuul (22348)"
Branch: master

commit e101cc165150ab075ef945ae88dbc61fc7b0a8a7
Author: Kyle MacLeod <email address hidden>
Date: Thu Mar 10 22:54:57 2022 -0500

    Fix logic to determine the existence of image list

    This commit addresses the issue for the prestage orchestration when no
    image list file has been uploaded.

    The fix is to properly check for the non-existing file.

    Test Plan:

    PASS:
    - Verify prestaging standalone with no image list uploaded
    - Verify prestaging orchestration with no image list uploaded
    - Verify prestaging with image list provided, default name
    - Verify prestaging case with image list provided, non-default name
    - Verify prestaging standalone with empty image list uploaded
      - ansible fails in this case, as expected

    Closes-Bug: 1964556

    Signed-off-by: Kyle MacLeod <email address hidden>
    Change-Id: I22c671968e32b10de83e0c352b64d4b6e2d02889