bpftool and perf should not be built as part of the kernel-rt build

Bug #1964432 reported by Jiping Ma
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
High
Jiping Ma

Bug Description

Brief Description
-----------------
bpftool and perf will not be used in rt kernel, so we should not build them.

Severity
--------
Major

Steps to Reproduce
-------------------
 ls /localdisk/loadbuild/jma1/stx-master-0301/rt/rpmbuild/RPMS/bpftool-
bpftool-5.10.74-200.2023.tis.rt.el7.x86_64.rpm bpftool-debuginfo-5.10.74-200.2023.tis.rt.el7.x86_64.rpm

Expected Behavior
-----------------
there is not bpftool and perf rpm package after build rt kernel.

Actual Behavior
---------------
there is bpftool and perf rpm package after build rt kernel.

Reproducibility
----------------
reproducible (happened 2/2)

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
recent stx master load after the 5.10 kernel merged

Last Pass
----------

Timestamp/Logs
--------------
N/A
Test Activity
--------------
Generate patch.

Workaround
----------
Unknown

Jiping Ma (jma11)
Changed in starlingx:
assignee: nobody → Jiping Ma (jma11)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kernel (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/kernel/+/832910

Changed in starlingx:
status: New → In Progress
Jiping Ma (jma11)
summary: - bpftool should not be built as part of the kernel-rt build
+ bpftool and perf should not be built as part of the kernel-rt build
description: updated
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → High
tags: added: stx.7.0 stx.distro.other
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kernel (master)

Reviewed: https://review.opendev.org/c/starlingx/kernel/+/832910
Committed: https://opendev.org/starlingx/kernel/commit/379208398cde67b9741670c2571d0bd76b707677
Submitter: "Zuul (22348)"
Branch: master

commit 379208398cde67b9741670c2571d0bd76b707677
Author: Jiping Ma <email address hidden>
Date: Wed Mar 9 22:55:00 2022 -0500

    kernel-rt: Do not build bpftool and perf packages

    Prior to this commit, the bpftool and perf packages would be built by
    kernel-std and kernel-rt spec files separately, and only the packages
    built from the kernel-std spec file would be included in the ISO image.

    However, merely having the kernel-rt spec file build the bpftool and
    perf packages results in conflicts when preparing StarlingX binary patch
    files that include all kernel and kernel-related RPM packages. Hence,
    this commit makes the kernel-rt.spec file not build the bpftool and perf
    packages by default.

    We should also note that work in the mainline kernel is ongoing
    (https://lwn.net/Articles/812503/) to allow BPF and to work well with
    the preempt-rt patchset after concerns were raised
    (https://lwn.net/Articles/802884/). The 5.10 kernel does have many of
    these changes in place, but to provide the best performance while
    avoiding any possible remaining issues with BPF, it is best not to build
    bpftool and perf.

    Verification:
    - After rt kernel build is complete, confirm that the bpftool and perf
      packages for rt kernel do not exist in the RPM package directory,
      using the following command, which does not return output:
        ls "${MY_BUILD_DIR}/rt/rpmbuild/RPMS/" | grep -e bpftool -e perf
    - Confirm that an ISO image built with this patch is successfully
      installed into two VMs in All-in-One simplex mode, one with the
      standard profile and another with the low-latency profile.
    - Confirm that the aforementioned VMs' Ansible bootstrap procedures pass
      as well.

    Closes-Bug: #1964432

    Change-Id: Ifda79d15707a0d36dddd0fd19b75656f9aa5437a
    Signed-off-by: Jiping Ma <email address hidden>
    [mvb: Update commit message to address code review comments and test the
     commit further.]
    Signed-off-by: M. Vefa Bicakci <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.