Updates not being copied to proper location when creating bootloader iso

[Shrikumar Sharma]

Brief Description

Update RPMs are not being copied to the proper location when creating the bootloader iso. This is because the location has changed across releases and
the path has not been updated fully.
This causes an updated kickstart to be ignored and a default kickstart is
always used instead.

Severity

<Major: System/Feature is usable but degraded>

Steps to Reproduce

run any scenario that uses prestaged data generated for upgrade or reinstall.
For example

prestage subcloud for reinstall
reinstall subcloud

Expected Behavior
The correct kickstart is downloaded to the subcloud causing subcloud to install packages from prestaged content.

Actual Behavior
The default kickstart is downloaded to the subcloud causing subcloud to download
packages from the systemcontroller.

Reproducibility

issue is 100% reproducible

System Configuration
DC

Last Pass
new test scenario.

Timestamp logs

In the logs bellow you can see all the packages that were donwloaded from the subcloud6 (oam_ip: 2620:10A:A001:A103::1129
 | bmc_ip: 2620:10a:a001:a102::142)
lighttpd-access_subcloud6_get_requests.log

Test Activity

Feature Testing

Workaround

none

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/utilities/+/832692
Committed: https://opendev.org/starlingx/utilities/commit/468d465c69aae13179d259c0fa527d2b54b69e4f
Submitter: "Zuul (22348)"
Branch: master

commit 468d465c69aae13179d259c0fa527d2b54b69e4f
Author: Shrikumar Sharma <email address hidden>
Date: Tue Mar 8 15:22:35 2022 -0500

    Path to kickstart files does not exist

    On newer releases, when gen-bootloader-iso.sh is executed,
    it extracts the contents of the platform-kickstarts rpm
    (if it was updated and provided as a patch) to
    ${WORKDIR}/www/pages/feed/rel-${ISO_VERSION}. It should
    actually extract it to
    ${WORKDIR}/var/www/pages/feed/rel-${ISO_VERSION} (where
    ${WORKDIR} is a temporary directory).

    Since the path is incorrect, incorrect behaviour is
    observed on the subcloud.

    Test Plan:

    PASS: Verify that the contents of platform-kickstarts rpm are
          extracted to
          ${WORKDIR}/var/www/pages/feed/rel-${ISO_VERSION}.

    Closes-Bug: 1964271

    Change-Id: Ibfc9e878a530c921437dcf9348427e2e32a05344
    Signed-off-by: Shrikumar Sharma <email address hidden>