Prestaged packages is not being using to upgrade subclouds

[Shrikumar Sharma]

Brief Description
Prestaged packages is not being using for upgrade

Severity
<Major: System/Feature is usable but degraded>

Steps to Reproduce
prestage a subcloud for upgrade
upgrade subcloud

Expected Behavior
In the best timing scenario, no images and packages should be downloaded while subclouds is being upgraded.

Actual Behavior
The packages are being donwloaded while the subclouds is being upgraded

Reproducibility
issue is 100% reproducible

System Configuration
DC

Last Pass
new test scenario.

Timestamp/Logs
Collecting logs...

Test Activity
Feature Testing

Workaround
None

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/metal/+/832119

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/metal/+/832119
Committed: https://opendev.org/starlingx/metal/commit/710452d2e5c79a2f5a0d61eab19ec68324044057
Submitter: "Zuul (22348)"
Branch: master

commit 710452d2e5c79a2f5a0d61eab19ec68324044057
Author: Shrikumar Sharma <email address hidden>
Date: Fri Mar 4 12:32:49 2022 -0500

    Install packages from platform backup if prestage iso is absent

    When the %pre code in post_miniboot_controller.cfg kickstart is run,
    it checks if a prestage iso is present; if one is not, then it
    attempts to download from the systemcontroller. The solution is
    to add /opt/platform-backup/<release-id> as a repo of higher
    priority than download, but lesser than prestage-iso,
    in the %pre section in post_miniboot_controller.cfg.

    Test Plan

    PASS: Verify that packages are retrieved from
          /opt/platform-backup/<release-id> if they have been prestaged

    PASS: Verify that packages are downloaded from systemcontroller
          for installation if packages are not prestaged in
          /opt/platform-backup/<release-id>

    Closes-Bug: 1963709
    Change-Id: Ibd2fe8d555c47da16e181b03703374bfd73731e3
    Signed-off-by: Shrikumar Sharma <email address hidden>

[Ghada Khalil (gkhalil)]

screening: stx.7.0 / medium - related to new feature development: https://storyboard.openstack.org/#!/story/2009799