upgrade abort from stx.7.0 downgrade to stx.6.0 failed

[Bin Qian]

Brief Description:

After upgrading the controller-1 downgrade fails from stx.7.0 (master branch) to stx.6.0 . This was observed in AIO-DX system while downgrading controller-1.

severity

 ** Major

Steps to Reproduce

Setup AIO-DX system for upgrade . Install 21.12 load
Upgrade controller-1 as per upgrade procedure. Import 22.06 load and follow upgrade procedure until controller-1 upgrade is complete.
Abort the upgrade
Downgrade the upgrade.
Downgrade failure was seen as the logs show below

 **

Expected Behavior

Downgrade successful from stx master load

Actual Behavior

As perthe description downgrade failure

Reproducibility

100% reproducible.

System Configuration

AIO-DX system

Timestamp/Logs

Mirroring software repository (may take several minutes)...
[anaconda] 1:main* 2:shell 3:log 4:storage-log 5:> SwitcDonelt+Tab or Ctrl-o
                                                               Installing pxeboot files for release rel-22.02 from /www/pages/feed/rel-22.02/Packages/pxe-network-instal================================================================================
================================================================================
Error

There was an error running the kickstart script at line 1353. This is a fatal
error and installation will be aborted. The details of this error are:

find: '/www/pages/updates/rel-22.02/Packages': No such file or directory
~/pxe-network-installer /www/pages
1063391 blocks
cp: cannot stat '/tmp/pxe-network-installer/pxeboot/rel-22.02': No such file or
directory

Installation failed.

 **

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/829943

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/metal/+/829944

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/829943
Committed: https://opendev.org/starlingx/config/commit/555c541eebd5d7ff093212510cc6972f80325fc4
Submitter: "Zuul (22348)"
Branch: master

commit 555c541eebd5d7ff093212510cc6972f80325fc4
Author: Bin Qian <email address hidden>
Date: Thu Feb 10 10:17:45 2022 -0500

    Add api to query an upgrade is in progress

    Add api to query an upgrade is in progress. This is to
    support kickstarts to avoid processing installer RPMs
    in future releases.

    This change introduces a new sysinv API to query if an
    upgrade is in progress (i.e, upgrade starts, but not
    abort).

    TCs:
        Upgrade from 21.05 -> 21.12 abort after controller-1
            upgrade completed
        Upgrade from 21.05 -> 21.12
        Upgrade from 21.12 -> 22.02 abort after controller-1
            upgrade completed
        Upgrade from 21.12 -> 22.02
        load delete after 21.05 -> 21.12 upgrade abort
        load delete after 21.05 -> 21.12 upgrade complete
        load delete after 21.12 -> 22.02 upgrade abort
        load delete after 21.12 -> 22.02 upgrade complete

    Partial-bug: 1961424

    Change-Id: Iaa49acca0dd365601fa2475c22aee2a4f668eb4d
    Signed-off-by: Bin Qian <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/metal/+/829944
Committed: https://opendev.org/starlingx/metal/commit/46f41901d65429e1d13410276f530e82cd63033c
Submitter: "Zuul (22348)"
Branch: master

commit 46f41901d65429e1d13410276f530e82cd63033c
Author: Bin Qian <email address hidden>
Date: Thu Feb 10 10:26:48 2022 -0500

    Do not install N+1 release unless upgrade in progress

    During upgrade, installer RPMs from release N need to be installed
    to host (release N+1).
    During downgrade, installer RPMs from release N+1 don't need to be
    installed to host (release N)
    Currently installer from "the other release" is installed to host
    regardless an upgrade is in progress or no by kickstarts. This
    requires the kickstarts on release N to understand the structure of
    installer RPM of future release. The installer from "the other
    release" only useful is when an upgrade is in progress (to provide
    installer when downgrade is required).

    This change removes the step to install RPMs from other release to
    host when upgrade is not in progress.

    TCs:
        Upgrade from 21.05 -> 21.12 abort after controller-1
            upgrade completed
        Upgrade from 21.05 -> 21.12
        Upgrade from 21.12 -> 22.02 abort after controller-1
            upgrade completed
        Upgrade from 21.12 -> 22.02
        load delete after 21.05 -> 21.12 upgrade abort
        load delete after 21.05 -> 21.12 upgrade complete
        load delete after 21.12 -> 22.02 upgrade abort
        load delete after 21.12 -> 22.02 upgrade complete

    Depends-on: https://review.opendev.org/c/starlingx/config/+/829943
    Closes-bug: 1961424

    Change-Id: I86edbe09410d3df9b9440d89208af90f0eb1fd09
    Signed-off-by: Bin Qian <email address hidden>

[Ghada Khalil (gkhalil)]

screening: stx.7.0 / low - upgrades are only best effort in starlingx