pci-irq-affinity-agent rpm failing to build

[Thiago Paiva Brito]

Brief Description
-----------------
The pci-irq-affinity-agent rpm package is failing to build, breaking up the StarlingX build as a whole

Severity
--------
Critical: System/Feature is not usable due to the defect

Steps to Reproduce
------------------
build-pkgs [pci-irq-affinity-agent]

Expected Behavior
------------------
Package is build succesfully

Actual Behavior
----------------
srpm package builds, but rpm package fails

Reproducibility
---------------
100% reproducible during build

System Configuration
--------------------
-

Branch/Pull Time/Commit
-----------------------
http://mirror.starlingx.cengn.ca/mirror/starlingx/master/centos/monolithic/20220127T053000Z

Last Pass
---------
http://mirror.starlingx.cengn.ca/mirror/starlingx/master/centos/monolithic/20220126T053000Z

Timestamp/Logs
--------------
Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/pci-irq-affinity-agent-1.0-28.tis.x86_64
RPM build errors:
error: Installed (but unpackaged) file(s) found:
   /usr/lib64/python2.7/site-packages/tests/__init__.py
   /usr/lib64/python2.7/site-packages/tests/__init__.pyc
   /usr/lib64/python2.7/site-packages/tests/__init__.pyo
   /usr/lib64/python2.7/site-packages/tests/test_nova_provider.py
   /usr/lib64/python2.7/site-packages/tests/test_nova_provider.pyc
   /usr/lib64/python2.7/site-packages/tests/test_nova_provider.pyo
    Installed (but unpackaged) file(s) found:
   /usr/lib64/python2.7/site-packages/tests/__init__.py
   /usr/lib64/python2.7/site-packages/tests/__init__.pyc
   /usr/lib64/python2.7/site-packages/tests/__init__.pyo
   /usr/lib64/python2.7/site-packages/tests/test_nova_provider.py
   /usr/lib64/python2.7/site-packages/tests/test_nova_provider.pyc
   /usr/lib64/python2.7/site-packages/tests/test_nova_provider.pyo
Child return code was: 1
EXCEPTION: [Error()]
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 89, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 582, in do
    raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
Error: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/pci-irq-affinity.spec

Test Activity
-------------
Build

Workaround
----------
N/A

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/utilities/+/826669
Committed: https://opendev.org/starlingx/utilities/commit/58e282f4ba2801fef0168e50500163b0061dde05
Submitter: "Zuul (22348)"
Branch: master

commit 58e282f4ba2801fef0168e50500163b0061dde05
Author: Thiago Brito <email address hidden>
Date: Thu Jan 27 10:30:21 2022 -0300

    Fixing pci-irq-affinity-agent centos packaging

    On commit 27c8759f47d787f0aaf569b83eafb5db5562acee we introduced some
    unittests for pci-irq-affinity-agent, but the tests folder was wrongly
    placed as a standalone package on the site-packages due to its location
    on the repository. This commit fixes that by moving those tests to the
    pci_irq_affintity package.

    TEST PLAN
    PASS tox tests
    PASS build-pkgs for centos

    Closes-Bug: #1959222
    Signed-off-by: Thiago Brito <email address hidden>
    Change-Id: Ib7631aedab321ab94d09992d773d0cd9e4658379