stx-openstack: openstackhelm/nova and openstackhelm/heat images being downloaded

[Thiago Paiva Brito]

Brief Description
-----------------
When installing stx-openstack, we perceived that some images were missed to be overwritten on the armada application manifest, namely openstackhelm/nova and openstackhelm/heat

Severity
--------
<Minor: System/Feature is usable with minor issue>

Steps to Reproduce
------------------
Just install stx-openstack and verify the images that were downloaded using `system registry-image-list`

Expected Behavior
------------------
Seeing this:
| docker.io/starlingx/stx-heat |
| docker.io/starlingx/stx-nova |

Actual Behavior
----------------
Seeing this:
| docker.io/openstackhelm/heat |
| docker.io/openstackhelm/nova |
| docker.io/starlingx/stx-heat |
| docker.io/starlingx/stx-nova |

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
All configurations

Branch/Pull Time/Commit
-----------------------
2022-01-21

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Downstream evaluation

Workaround
----------
Overwrite the images directly via system helm-override-update

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/openstack-armada-app/+/825876

[Ghada Khalil (gkhalil)]

screening: stx.7.0 / medium - openstack issue; fix is already in progress

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/openstack-armada-app/+/825876
Committed: https://opendev.org/starlingx/openstack-armada-app/commit/88e18ec9c94d473abcf22377007c152ccbf87c0a
Submitter: "Zuul (22348)"
Branch: master

commit 88e18ec9c94d473abcf22377007c152ccbf87c0a
Author: Thiago Brito <email address hidden>
Date: Fri Jan 21 16:15:04 2022 -0300

    Providing overrides for newer images on OSH

    After the upversion of OSH, we perceived that stx-openstack is still
    downloading the images "openstackhelm/nova" and "openstackhelm/heat".
    These are default images on the OSH charts and we want to overwrite them
    with stx-heat and stx-nova images so we don't bring unnecessary and
    probably unsupported images to the StarlingX registry and stx-openstack
    charts.

    TEST PLAN
    PASS Install stx-openstack and made sure no openstackhelm/* images are
         being downloaded.

    Log of the image downloading: https://paste.opendev.org/show/812347/

    Closes-Bug: #1958677

    Signed-off-by: Thiago Brito <email address hidden>
    Change-Id: I365a6f373cced98cb62aa51626a9657abad41b08