build failure: golang-1.16.12

[Scott Little]

Brief Description
-----------------

CENGN master branch builds, compiler layer as well as monolithic, failed on the
upgraded package golang-1.16.12.

Golang was upgraded for this build by ...

    https://review.opendev.org/c/starlingx/to/+/823545

error message was ...

   RPM build errors:
   + cd go
   BUILDSTDERR: /var/tmp/rpm-tmp.h96QD2: line 35: cd: go: No such file or directory

It should read 'cd go-16.12' based on the post download_mirrors.sh tarball. Now download_mirrors.sh was asked to modify the base directory of go1.16.12.src.tar.gz to read 'go-16.12' by this line in centos_tarball-dl.lst

   go1.16.12.src.tar.gz#go-16.12#https://storage.googleapis.com/golang/go1.16.12.src.tar.gz##https##

At this stage download_mirrors.sh will not re-download, so we must change the 'cd' in the spec to match, rather than modifying 'centos_tarball-dl.lst'

Severity
--------
Critical

Steps to Reproduce
------------------
build-pkgs

Expected Behavior
------------------
all packages build

Actual Behavior
----------------
golang-1.16.12 failes to build. Perhaps 2 dozen additional package fail that depend on golang.

Reproducibility
---------------
<Reproducible/Intermittent/Seen once>
State if the issue is 100% reproducible, intermittent or seen once. If it is intermittent, state the frequency of occurrence

System Configuration
--------------------
<One node system, Two node system, Multi-node system, Dedicated storage, https, IPv4, IPv6 etc.>

Branch/Pull Time/Commit
-----------------------
2022-01-18 aprox 9 pm EST

Last Pass
---------
2022-01-17

Timestamp/Logs
--------------
from golang 16.12 build log ....

   RPM build errors:
   + cd go
   BUILDSTDERR: /var/tmp/rpm-tmp.h96QD2: line 35: cd: go: No such file or directory

Test Activity
-------------
Build

Workaround
----------
temporarily revert the commit

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/compile/+/825340

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/compile/+/825340
Committed: https://opendev.org/starlingx/compile/commit/f00bb85d0f6e85154697950a89e2ce42e2c19b6e
Submitter: "Zuul (22348)"
Branch: master

commit f00bb85d0f6e85154697950a89e2ce42e2c19b6e
Author: Chris Friesen <email address hidden>
Date: Wed Jan 19 11:04:05 2022 -0500

    Fix up golang 1.16.12 tarball path for centos

    The top-level directory in the golang tarball was renamed as part
    of the mirroring process, so we need to tweak the spec file to match.

    Closes-Bug: 1958413
    Change-Id: I4363a69baa3041ad389e43945e4c9931776b6e28
    Signed-off-by: Chris Friesen <email address hidden>