Backup is not failing with failure of Save list of local registry images

[Heron Vieira]

Brief Description
-----------------
The simplex upgrade was in the started state, after a failure on the "Save list of local registry images" step. Also, there was no backup file after the upgrade-start state.

Severity
--------
Major: silent failure.No error message

Steps to Reproduce
------------------
Start simplex upgrade applying a service parameter change on local registry.

After upgrade start there was no backup file created and there were no errors on upgrade health check and upgrade start.

Expected Behavior
------------------
The upgrade should not go to the upgrade-started step if there was an error in the process.

Actual Behavior
----------------
As per the description, there was no failure or error on upgrade start and a backup file was not created.

Reproducibility
---------------
100% reproducible

System Configuration
-------------------
IPv6, AIO-SX

Branch/Pull Time/Commit
-----------------------
N/A

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Upgrade test

Workaround
----------
N/A

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/823323

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/823323
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/8cd1d0693f08be9a37996e33256a4a0ef69ba6b4
Submitter: "Zuul (22348)"
Branch: master

commit 8cd1d0693f08be9a37996e33256a4a0ef69ba6b4
Author: Heron Vieira <email address hidden>
Date: Tue Jan 11 16:23:56 2022 -0300

    Force fail on rescue for the ansible backup.

    Added task on rescue to force an exit error code on ansible process

    Test Plan:

    PASS: Tested upgrade forcing a error on "Save list of local registry images", the error was properly caught and the upgrade was successfully aborted.

    Closes-Bug: #1956249
    Signed-off-by: Heron Vieira <email address hidden>
    Change-Id: Ib695c09a7f783989eaec09324c914e0198099d17
    Signed-off-by: Heron Vieira <email address hidden>