Build failure of stx-nova container on spice-html5

[Scott Little]

Brief Description
-----------------
CENGN failed top build stx-nova after 5 tries
All tries failed on an attempt to clone from
https://gitlab.freedesktop.org/spice/spice-html5.git
failed with error 504.

Perhaps we should switch to ...
https://github.com/freedesktop/spice-html5.git

Severity
--------
Provide the severity of the defect.
Critical

Steps to Reproduce
------------------
Write down the steps to reproduce the issue

Expected Behavior
------------------
clone passes. Conatainer build fails.

Actual Behavior
----------------
failure to clone spice-html5

Reproducibility
---------------
100%

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
Jan 1 2022

Last Pass
---------
Dec 31 2021

Timestamp/Logs
--------------
 git clone -b spice-html5-0.1.6 --depth 1 https://gitlab.freedesktop.org/spice/spice-html5.git /usr/share/spice-html5
Cloning into '/usr/share/spice-html5'...
fatal: unable to access 'https://gitlab.freedesktop.org/spice/spice-html5.git/';: The requested URL returned error: 504

Test Activity
-------------
Build

Workaround
----------
clone from github instead.

[Thiago Paiva Brito (outbrito)]

This value is provided on the default Dockerfile for LOCI here: https://github.com/openstack/loci/blob/master/Dockerfile#L29

I think it is overwritable.

PS.: I do see some intermittence on that gitlab when I try to access it on my browser. That may be the reason today's build went through OK.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/upstream/+/823546

[Ghada Khalil (gkhalil)]

screening: intermittent build issue affecting both the r/stx.6.0 and master branch; will not hold up stx.6.0 given a retry is successful, so we can likely live with that.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Thiago Paiva Brito <email address hidden>" on branch: master
Review: https://review.opendev.org/c/starlingx/upstream/+/823546
Reason: The change on PS 3 of https://review.opendev.org/c/starlingx/root/+/823578 makes this one unecessary

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/root/+/823578
Committed: https://opendev.org/starlingx/root/commit/00bd632a68b8172f5d4baec2b1e4f8a08b9d5be5
Submitter: "Zuul (22348)"
Branch: master

commit 00bd632a68b8172f5d4baec2b1e4f8a08b9d5be5
Author: Thiago Brito <email address hidden>
Date: Wed Jan 5 16:01:12 2022 -0500

    Provide a different source repo for spice-html5

    We are noticing some intermittence on the gitlab service that provides
    the spice-html5 source code defined on the default location on LOCI at
    [1]. This commit creates the possibility to override the SPICE_REPO
    location so we can decide for each image if we want to use a different
    source and ref for spice-html5.

    This patch also defaults to the github mirror of spice-html5 for all stx
    images.

    [1] https://github.com/openstack/loci/blob/master/Dockerfile#L29

    TEST PLAN
    PASS Build stx-nova image with SPICE_REPO and SPICE_REF changed
    PASS Build images with a mix of changed and unchanged
         .stable_docker_images WRT spice-html5 source

    Depends-On: https://review.opendev.org/c/openstack/loci/+/823577
    Closes-Bug: #1956173
    Signed-off-by: Thiago Brito <email address hidden>
    Change-Id: I6872e42b08b2774666691b5dc4f0ff534160434a