build container failes on filelock-3.4.2.tar.gz

[Scott Little]

Brief Description
-----------------
Can't create the StarlingX build container since ~Dec 26.
Looks like fileutil was upgraded and is no longer compatible with
python 2.7.

Severity
--------
Critical: Can't create a build container

Steps to Reproduce
------------------
cd stx-tools
docker build --build-arg MYUID=18876 --build-arg MYUNAME=jenkins --ulimit core=0 --network host --tag jenkins:master-flock-20211230T151249Z-builder-image --file Dockerfile .

Expected Behavior
------------------
build container is created

Actual Behavior
----------------
Can't create the build container

Reproducibility
---------------
100% if build container is not in the docker cache

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
Dec 30 / 2021

Last Pass
---------
Dec 19 / 2021

Timestamp/Logs
--------------
10:14:08 + docker build --build-arg MYUID=18876 --build-arg MYUNAME=jenkins --ulimit core=0 --network host --tag jenkins:master-flock-20211230T151249Z-builder-image --file ../Dockerfile .
...
10:43:58 Step 28/52 : RUN pip install -c /home/$MYUNAME/builder-constraints.txt pbr==5.6.0 --upgrade && pip install -c /home/$MYUNAME/builder-constraints.txt git-review==2.1.0 --upgrade && pip install -c /home/$MYUNAME/builder-constraints.txt python-subunit==1.4.0 junitxml==0.7 testtools==2.4.0 --upgrade && pip install -c /home/$MYUNAME/builder-constraints.txt tox==3.23.0 --upgrade
...
10:44:13 Collecting filelock>=3.0.0 (from tox==3.23.0)
10:44:13 Downloading https://files.pythonhosted.org/packages/11/d1/22318a1b5bb06c9be4c065ad6a09cb7bfade737758dc08235c99cd6cf216/filelock-3.4.2.tar.gz (206kB)
10:44:13 Complete output from command python setup.py egg_info:
10:44:13 Traceback (most recent call last):
10:44:13 File "<string>", line 1, in <module>
10:44:13 File "/tmp/pip-build-Ax35i1/filelock/setup.py", line 1
10:44:13 from __future__ import annotations
10:44:13 SyntaxError: future feature annotations is not defined

Test Activity
-------------
Build

Workaround
----------
N/A

[Scott Little (slittle1)]

Intended to say 'filelock', not 'fileutil'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/tools/+/823208

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/tools/+/823208
Committed: https://opendev.org/starlingx/tools/commit/0d67f81bdff338c2f965a50aa3fccac08579ec60
Submitter: "Zuul (22348)"
Branch: master

commit 0d67f81bdff338c2f965a50aa3fccac08579ec60
Author: Scott Little <email address hidden>
Date: Thu Dec 30 11:21:12 2021 -0500

    Lock filelock to version 3.4.0 to retain python 2.7 support

    Filelock was upgraded to 3.4.2 from 3.4.0 over the holidays,
    and this breaks our build that requires python 2.7 compatibility.
    We'll stay with 3.4.0 which has worked for StarlingX for some time,
    rather than reverting to 3.2.1 which was the last with official
    python 2.7 support.

    Closes-Bug: 1956054
    Signed-off-by: Scott Little <email address hidden>
    Change-Id: I77e595f7fcf081707da78f2fba8df70bf19033de

[Scott Little (slittle1)]

platformdirs was also upgraded over the holidays, and is also now breaking under python 2.7

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/tools/+/823215
Committed: https://opendev.org/starlingx/tools/commit/7bde482bcbee0d740446d7484a59d312e73e769b
Submitter: "Zuul (22348)"
Branch: master

commit 7bde482bcbee0d740446d7484a59d312e73e769b
Author: Scott Little <email address hidden>
Date: Fri Dec 31 09:54:04 2021 -0500

    Lock platformdirs to version 2.4.0 to retain python 2.7 support

    Platformdirs was upgraded to 2.4.1 from 2.4.0 over the holidays,
    and this breaks our build that requires python 2.7 compatibility.
    We'll stay with 2.4.0 which has worked for StarlingX for some time,
    rather than reverting to 2.0.2 which was the last with official
    python 2.7 support.

    Closes-Bug: 1956054
    Signed-off-by: Scott Little <email address hidden>
    Change-Id: I303429a744f4addf639f1ab88f03a06b52bc7144

[Ghada Khalil (gkhalil)]

Confirmed with Scott that these changes are required for r/stx.6.0 as well

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.6.0
Review: https://review.opendev.org/c/starlingx/tools/+/823545

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/tools/+/823545
Committed: https://opendev.org/starlingx/tools/commit/32f283894a8ad0417fa862edf77bafa8ceab94c8
Submitter: "Zuul (22348)"
Branch: r/stx.6.0

commit 32f283894a8ad0417fa862edf77bafa8ceab94c8
Author: Scott Little <email address hidden>
Date: Fri Dec 31 09:54:04 2021 -0500

    Lock platformdirs to version 2.4.0 to retain python 2.7 support

    Platformdirs was upgraded to 2.4.1 from 2.4.0 over the holidays,
    and this breaks our build that requires python 2.7 compatibility.
    We'll stay with 2.4.0 which has worked for StarlingX for some time,
    rather than reverting to 2.0.2 which was the last with official
    python 2.7 support.

    Closes-Bug: 1956054
    Signed-off-by: Scott Little <email address hidden>
    (cherry picked from commit 7bde482bcbee0d740446d7484a59d312e73e769b)
    Change-Id: Ibb700dadac300b4eb4c1c4cc58a29ff57767c26e