DX Upgrades do not include kickstart changes from patches

[David Sullivan]

Brief Description
Patched kickstart changes are not applied to controller-1 in DX upgrades. During the upgrade start process we incorrectly extract the base kickstarts used to pxeboot controller-1. This applies to both patched ISOs and regular patches.

Severity
Critical

Steps to Reproduce
Import a load in DX system
Apply a patch with a kickstart change to that load
Upgrade controller-1

Expected Behavior
Controller-1 installs with the patched kickstarts

Actual Behavior
Controller-1 installs with the base/unpatched kickstarts

Reproducibility
Reproducible

System Configuration
DX

Branch/Pull Time/Commit
Present in STX 4, 5 and 6

Last Pass
Never

Timestamp/Logs
NA

Alarms
NA

Test Activity
Feature Testing

Workaround
Possibly manually extract the kickstarts from /opt/patching after upgrade-start and before host-upgrade.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/update/+/822345

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/update/+/822345
Committed: https://opendev.org/starlingx/update/commit/83f5487c27db3df76ee9e235709a2eb3f4dfda80
Submitter: "Zuul (22348)"
Branch: master

commit 83f5487c27db3df76ee9e235709a2eb3f4dfda80
Author: David Sullivan <email address hidden>
Date: Mon Dec 20 09:03:07 2021 -0600

    Correct package selection during upgrade-start-pkg-extract

    During upgrade-start we call upgrade-start-pkg-extract to extract the
    kickstarts and pxeboot data from the N+1 load. This data is used to boot
    controller-1 in duplex environments. As these packages can be patched we
    need to select the latest version of the package.

    Currently the dnf repoquery call returns every version of the rpm
    queried. This results in the base version being used during the package
    extraction. This commit updates the command to use --latest-limit=1.
    The command is also updated to use --disablerepo=*. This will result in
    the command being restricted to the specified N+1 repos. Without the
    disablerepo option the N repo packages are included in the results.

    This brings the call in line with the behavior of
    utilities/utilities/platform-util/scripts/gen-bootloader-iso.sh

    Testing:
    AIO-DX upgrade with patched kickstart package

    Closes-Bug: 1955410
    Change-Id: Ia1cd778791b64133667327031305d0f1914aed2d
    Signed-off-by: David Sullivan <email address hidden>