Failure occurs after configuring the management interface bonding on controller-0 and unlocking it

[Teresa Ho]

Brief Description
-----------------
Initially the mgmt interface on controller-0 is enp25s0f0. When creating a mgmt bonded interface with enp25s0f0 and enp178s0f0, it always select enp178s0f0'MAC as the MAC of the bonding interface regardless of the order of the ports in 'host-if-add' command. After unlock controller-0, it fails.

Severity
--------
Critical

Steps to Reproduce
------------------
(1) Deploy a duplex AIO.
(2) On controller-0, create a mgmt bonding interface with previous mgmt interface and another interface which name is sorted in front of the previous mgmt interface.
(3) Unlock controller-0.

Expected Behavior
------------------
The controller unlocks successfully

Actual Behavior
----------------
Failed to unlock controller

Reproducibility
---------------
100%

System Configuration
--------------------
Two node system

Branch/Pull Time/Commit
-----------------------
master

Last Pass
---------
n/a

Timestamp/Logs
--------------
n/a

Test Activity
-------------
Testing

Workaround
----------
none

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/822321

[Ghada Khalil (gkhalil)]

screening: stx.7.0 / medium - this is a day 1 limitation and is only specific to changing a boot interface to a bond on a running system, so it's a very specific scenario

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/822321
Committed: https://opendev.org/starlingx/config/commit/1ec80ec80152f20c02541dd2ad00b4da201a0b6f
Submitter: "Zuul (22348)"
Branch: master

commit 1ec80ec80152f20c02541dd2ad00b4da201a0b6f
Author: Teresa Ho <email address hidden>
Date: Fri Dec 17 08:58:58 2021 -0500

    Fix AE mgmt interface reconfig

    When the mgmt interface is reconfigured from ethernet to a bonded
    interface after the first unlocked of controller-0, the mac address
    selected for the bonded interface may be changed depending on the new
    interface name added to the bond. This would cause failure in unlocking
    the controller because maintenance expects to receive commands from
    the original host mgmt mac instead of the mac address of the new
    interface.

    This commit is to take this case into account by keeping the mac address
    of the new bonded interface the same as the original host mgmt mac.

    Test Plan:
    PASS: Reconfigure mgmt interface from ethernet to bonded interface
    PASS: Reconfigure mgmt interface from vlan ethernet to vlan over AE

    Closes-Bug: 1955406

    Change-Id: I749a3691dedae00055e158d91b12456885f51d36
    Signed-off-by: Teresa Ho <email address hidden>