registry-token-server is not supported by the patch-restart-processes script

[Ghada Khalil]

Brief Description
-----------------
registry-token-server is not supported by the patch-restart-processes. This makes it more difficult to patch this process as an in-service patch.

Severity
--------
Minor - it's still possible to patch-back registry-token-server as an in-service patch, but more code is required. See the Workaround section.

Steps to Reproduce
-------------------
Examine the patch-restart-processes script

Expected Behavior
-----------------
registry-token-server should be supported by the script

Actual Behavior
---------------
registry-token-server is not supported by the script

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
any

Branch/Pull Time/Commit
------------------------
stx master (but also in r/stx.5.0)

Last Pass
---------
Never

Timestamp/Logs
---------------
N/A

Workaround
----------
Add code to restart the service as part of the patch-restart script. Similar to this example:
https://opendev.org/starlingx/update/src/branch/master/patch-scripts/EXAMPLE_0001/scripts/example-restart#L80

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/utilities/+/819363

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/utilities/+/819363
Committed: https://opendev.org/starlingx/utilities/commit/6e427ca8e827783380730fa243ded0ff6184397e
Submitter: "Zuul (22348)"
Branch: master

commit 6e427ca8e827783380730fa243ded0ff6184397e
Author: Teresa Ho <email address hidden>
Date: Thu Nov 25 13:24:08 2021 -0500

    Add registry-token-server to service process restart list

    This update added registry-token-server to patch-restart-processes to
    support safe restart of registry-token-server during in-service patching.

    Closes-Bug: 1952350

    Change-Id: Ifb750b960d669f65f9b827cc9bb6d3e063b9ee17
    Signed-off-by: Teresa Ho <email address hidden>