github dropped support for git protocol

[Scott Little]

Brief Description
-----------------
Github has dropped support for the 'git' protocal. We'll have to audit all manifests, docker files, etc. and switch to https protocol where required.

Severity
--------
Critical

Steps to Reproduce
------------------
docker build --ulimit core=0 --network host --tag starlingx/stx-aptly:master-debian-20211102T005600Z --file stx/dockerfiles/stx-aptly.Dockerfile

Expected Behavior
------------------
Aptly container builds

Actual Behavior
----------------
Aptly container fails to build

Reproducibility
---------------
100%

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
2021-11-02

Last Pass
---------
2021-11-01

Timestamp/Logs
--------------

Cloning git://github.com/masselstine/aptly-api-client.git to /tmp/pip-req-build-7stj6hci
Running command git clone -q git://github.com/masselstine/aptly-api-client.git /tmp/pip-req-build-7stj6hci
fatal: remote error:
The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
WARNING: Discarding git+git://github.com/masselstine/aptly-api-client.git. Command errored out with exit status 128: git clone -q git://github.com/masselstine/aptly-api-client.git /tmp/pip-req-build-7stj6hci Check the logs for full command output.
ERROR: Command errored out with exit status 128: git clone -q git://github.com/masselstine/aptly-api-client.git /tmp/pip-req-build-7stj6hci Check the logs for full command output.
The command '/bin/sh -c apt-get update && apt-get install --no-install-recommends -y sudo ssh git wget curl vim rpm2cpio cpio python3 python3-yaml python3-pip xz-utils file bzip2 dnsutils locales-all python3-apt dpkg-dev git-buildpackage fakeroot pristine-tar repo libdistro-info-perl proxychains && apt-get clean && rm -rf /var/lib/apt/lists/* && pip3 install gitpython requests python-debian pulpcore_client pulp_deb_client pulp_file_client progressbar git+git://github.com/masselstine/aptly-api-client.git && sed -i '/^proxy_dns*/d' /etc/proxychains.conf && sed -i 's/^socks4.*/socks5 127.0.0.1 8080/g' /etc/proxychains.conf && ln -sf /usr/local/bin/stx/stx-localrc /root/localrc && echo '. /usr/local/bin/finishSetup.sh' >> /root/.bashrc' returned a non-zero code: 1

Test Activity
-------------
Build

Workaround
----------
pull build containers from dockerhub

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/manifest/+/816358
Committed: https://opendev.org/starlingx/manifest/commit/99ea58653bfb9d480ff8df8f23e38521a7eeb77c
Submitter: "Zuul (22348)"
Branch: master

commit 99ea58653bfb9d480ff8df8f23e38521a7eeb77c
Author: Charles Short <email address hidden>
Date: Tue Nov 2 09:40:01 2021 -0400

    Use https instead of git for github.com

    Github has recently deprecated git in favor
    of https to improve site security. This results in repo
    command failing.

    See: https://github.blog/2021-09-01-improving-git-protocol-security-github/

    Partial-Bug: 1949479

    Signed-off-by: Charles Short <email address hidden>
    Change-Id: Ibdd38f71a4403c39c07dda9fcfafd88ebe6c77dd

[Ghada Khalil (gkhalil)]

Leaving open until Scott Little confirms there are no additional changes required in stx

[Scott Little (slittle1)]

Scanned docker files and other likely places. No further impact was identified.