build-tools/srpm-utils does not recognize /usr/bin/mkdir in spec files

Bug #1948968 reported by M. Vefa Bicakci
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
M. Vefa Bicakci

Bug Description

srpm-utils in cgcs-root/build-tools/srpm-utils does not recognize /usr/bin/mkdir as an alias for mkdir command. This breaks package preparation/builds when a spec file uses %{__mkdir} instead of mkdir, as %{__mkdir} expands to /usr/bin/mkdir.

One example is CentOS 8-Stream's iptables package.

I have prepared a quick-and-dirty patch to resolve this issue, and I am opening this bug as a placeholder to refer to.

Changed in starlingx:
assignee: nobody → M. Vefa Bicakci (vbicakci)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to root (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/root/+/815742

Changed in starlingx:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to root (master)

Reviewed: https://review.opendev.org/c/starlingx/root/+/815742
Committed: https://opendev.org/starlingx/root/commit/c73eb33d412dddb500d81401100009846352b945
Submitter: "Zuul (22348)"
Branch: master

commit c73eb33d412dddb500d81401100009846352b945
Author: M. Vefa Bicakci <email address hidden>
Date: Wed Oct 27 12:45:37 2021 -0400

    srpm-utils: Recognize /usr/bin/mkdir as well

    This commit allows the code in the srpm-utils script to recognize
    /usr/bin/mkdir (as an alias for mkdir).

    In summary, some SRPMs in CentOS 8 such as iptables make use of the
    %{__mkdir} macro, which expands to /usr/bin/mkdir, which in turn was not
    recognized by srpm-utils.

    Verification: build-pkgs --edit now works with a version of iptables
    imported from CentOS 8.

    Signed-off-by: M. Vefa Bicakci <email address hidden>
    Closes-Bug: #1948968
    Change-Id: I12d20797db91fecdac409b0535632ac97bd6ad47

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
tags: added: stx.build
tags: added: stx.6.0
Changed in starlingx:
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.