flock layer build fails on package stx-openstack-helm

[Scott Little]

Brief Description
-----------------
CENGN flock layer build failed on package stx-openstack-helm. The same issue failed the monolithic build as well.

The Changlog suggests one of these two commits as the most likely cause
./cgcs-root/stx/openstack-armada-app 01f6571912c9d88afcda481e64a385807bd2d4a9 2021-10-07 10:06:05 -0300 Thiago Brito <email address hidden> Update openstack-helm-infra commit
./cgcs-root/stx/SDO-rv-service bb6dec5d0d4909bee1644bfbb4e0e520ab89b753 2021-09-22 12:03:08 -0400 Thiago Brito <email address hidden> Upversion helm-toolkit to 0.2.19

https://review.opendev.org/c/starlingx/openstack-armada-app/+/808800
https://review.opendev.org/c/starlingx/SDO-rv-service/+/810464

Severity
--------
Critical

Steps to Reproduce
------------------
build-pkgs

Expected Behavior
------------------
all packages build

Actual Behavior
----------------
packages stx-openstack-helm-1.0-116.tis.src.rpm and stx-platform-helm-1.0-40.tis.src.rpm fail to build

Reproducibility
---------------
100%

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
2021-10-13 04:30:00 UTC

Last Pass
---------
2021-10-12 04:30:00 UTC

Timestamp/Logs
--------------
make[1]: Entering directory `/builddir/build/BUILD/stx-openstack-helm-1.0/helm-charts'
if [ -f fm-rest-api/Makefile ]; then make -C fm-rest-api; fi
if [ -f fm-rest-api/requirements.yaml ]; then helm dep up fm-rest-api; fi
Hang tight while we grab the latest from your chart repositories...
BUILDSTDERR: 2021-10-13T04:20:58.112Z DEBUG [8] Incoming request: /charts/index.yaml {"reqID": "96966d3b-92ab-442a-ac32-99a73240ae32"}
BUILDSTDERR: 2021-10-13T04:20:58.112Z DEBUG [8] Entry found in cache store {"repo": "", "reqID": "96966d3b-92ab-442a-ac32-99a73240ae32"}
BUILDSTDERR: 2021-10-13T04:20:58.112Z DEBUG [8] Fetching chart list from storage {"repo": "", "reqID": "96966d3b-92ab-442a-ac32-99a73240ae32"}
BUILDSTDERR: 2021-10-13T04:20:58.112Z DEBUG [8] Change detected between cache and storage {"repo": "", "reqID": "96966d3b-92ab-442a-ac32-99a73240ae32"}
BUILDSTDERR: 2021-10-13T04:20:58.112Z DEBUG [8] Regenerating index.yaml {"repo": "", "reqID": "96966d3b-92ab-442a-ac32-99a73240ae32"}
BUILDSTDERR: 2021-10-13T04:20:58.112Z DEBUG [8] Loading charts packages from storage (this could take awhile) {"repo": "", "total": 1, "reqID": "96966d3b-92ab-442a-ac32-99a73240ae32"}
BUILDSTDERR: 2021-10-13T04:20:58.120Z DEBUG [8] Adding chart to index {"repo": "", "name": "keystone-api-proxy", "version": "0.1.0", "reqID": "96966d3b-92ab-442a-ac32-99a73240ae32"}
BUILDSTDERR: 2021-10-13T04:20:58.121Z DEBUG [8] index.yaml regenerated {"repo": "", "reqID": "96966d3b-92ab-442a-ac32-99a73240ae32"}
BUILDSTDERR: 2021-10-13T04:20:58.121Z DEBUG [8] Entry saved in cache store {"repo": "", "reqID": "96966d3b-92ab-442a-ac32-99a73240ae32"}
BUILDSTDERR: 2021-10-13T04:20:58.121Z INFO [8] Request served {"path": "/charts/index.yaml", "comment": "", "latency": "8.789147ms", "clientIP": "127.0.0.1", "method": "GET", "statusCode": 200, "reqID": "96966d3b-92ab-442a-ac32-99a73240ae32"}
BUILDSTDERR: 2021-10-13T04:20:58.121Z DEBUG [8] index-cache.yaml saved in storage {"repo": "", "reqID": "96966d3b-92ab-442a-ac32-99a73240ae32"}
...Successfully got an update from the "local" chart repository
Update Complete. ⎈Happy Helming!⎈
BUILDSTDERR: Error: can't get a valid version for repositories helm-toolkit. Try changing the version constraint in Chart.yaml
BUILDSTDERR: make[1]: *** [init-fm-rest-api] Error 1
make[1]: Leaving directory `/builddir/build/BUILD/stx-openstack-helm-1.0/helm-charts'
BUILDSTDERR: make: *** [fm-rest-api] Error 2

See Also
http://mirror.starlingx.cengn.ca/mirror/starlingx/master/centos/flock/20211013T032334Z/logs/

Test Activity
-------------
Build

Workaround
----------
N/A

[Thiago Paiva Brito (outbrito)]

The make of fm-rest-api (which is a dependency for stx-openstack-helm) is failing because commit 01f6571912c9d88afcda481e64a385807bd2d4a9 changed the available version of helm-toolkit and the review that fixes that version for fm-rest-api wasn't approved yet.

Please take a look at https://review.opendev.org/c/starlingx/helm-charts/+/810463

Also, after that, platform-armada-app will fail for a similar reason, the review that fixes it is https://review.opendev.org/c/starlingx/platform-armada-app/+/810462

[Frank Miller (sensfan22)]

Based on Thiago's updates, this LP can now be marked as fix released.