sysadmin user not using bash shell

[Jim Gauld]

Brief Description
-----------------
sysadmin user is configured with /bin/sh and not /bin/bash . This is inconsistent with 'root'.
This has unintentional side effects with in-line scripting and bash-completion doesn't work.
i.e., enter a command like, "kubectl desc<tab>" and hitting the tab repeatedly completes the command and so on, this dramatically improves user interactive experience.
Many users may not notice the difference.

Current configuration of sysadmin user has /bin/sh .
grep -e sysadmin -e root /etc/passwd
root:x:0:0:root:/root:/bin/bash
sysadmin:x:42425:345::/home/sysadmin:/bin/sh

The sysadmin user is added via the following code:
./stx/config-files/sudo-config/centos/sudo-config.spec
%pre
getent group sys_protected >/dev/null || groupadd -f -g 345 sys_protected
getent passwd sysadmin > /dev/null || \
useradd -m -g sys_protected -G root \
    -d /home/sysadmin -p %{SYSADMIN_P} \
    -s /bin/sh sysadmin 2> /dev/null || :

Severity
--------
Minor: System is usable, with minor issue.

Steps to Reproduce
------------------
Install lab. Login as sysadmin.
echo $SHELL

Expected Behavior
------------------
login as sysadmin.
echo $SHELL
/bin/bash

bash-completion of kubectl commands work.

Actual Behavior
----------------
echo $SHELL
/bin/sh

bash-completion of kubectl commands don't work.

Reproducibility
---------------
100%, but some designers have seen bash-completion work sometimes on HW.

System Configuration
--------------------
AIO-SX. This affects all systems.

Branch/Pull Time/Commit
-----------------------
NA.

Last Pass
---------
NA. Day one config.

Timestamp/Logs
--------------
NA.

Test Activity
-------------
Developer Testing of kubernetes upgrade.

Workaround
----------
Manually enter bash shell.
bash

Modify /etc/passwd 'sysadmin' user to use /bin/bash.

[Jim Gauld (jgauld)]

Modifying sudo-config.spec only fixes initial install of the ISO.
There is something still that overrides this configuration, TBD.

[Jim Gauld (jgauld)]

The /etc/passwd is regenerated and configured during bootstrap, and later during upgrade and runtime.
./stx/stx-puppet/puppet-manifests/src/modules/platform/manifests/users.pp
  -> user { 'sysadmin':
    ensure => 'present',
    groups => ['root', $::platform::params::protected_group_name],
    home => '/home/sysadmin',
    password => $sysadmin_password,
    password_max_age => $sysadmin_password_max_age,
    shell => '/bin/sh',
  }

The shell should be changed to '/bin/bash'.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/842014

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/842014
Committed: https://opendev.org/starlingx/stx-puppet/commit/83a6c5a25114ebe6626b2a0215af07a91ee5517b
Submitter: "Zuul (22348)"
Branch: master

commit 83a6c5a25114ebe6626b2a0215af07a91ee5517b
Author: Kaustubh Dhokte <email address hidden>
Date: Mon May 16 20:49:54 2022 -0400

    Change 'sysadmin' default shell to bash

    The user 'sysadmin' by default uses /bin/sh. Changing it to
    /bin/bash will enable k8s commands autocompletion.

    Test Plan: (On both CentOS and Debian)
    PASS: Install AIO-SX lab. Verify k8s commands autocomplete
          works. Perform lock, unlock and reboot operations.
          Verify that the sysadmin continues to use /bin/bash as the
          default shell and k8s autocomplete works after each
          operation

    Closes-bug: 1942455

    Signed-off-by: Kaustubh Dhokte <email address hidden>
    Change-Id: Ibe2f097b77d7c2b6842b309faf7b5a35a89fad49