/etc/etcd/ca.key is missing on controller-1 after upgrade

[Andy]

Brief Description
-----------------
For a DX system, /etc/etcd/ca.key is missing on controller-1 after upgrade from 20.06 to 21.05.

Severity
--------
Minor

Steps to Reproduce
------------------
- Upgrade a DX system from 20.06 to 21.05
- After the upgrade, login to controller-1 and verify the etcd ca.key file, the file is missing

controller-1:~$ ls /etc/etcd/ca.key
ls: cannot access /etc/etcd/ca.key: No such file or directory
controller-1:~$

The same file exists on controller-0:
controller-0:~$ ls /etc/etcd/ca.key
/etc/etcd/ca.key
controller-0:~$

Expected Behavior
------------------
The /etc/etcd/ca.key file exists on both controllers.

Actual Behavior
----------------
The /etc/etcd/ca.key file doesn't exist on controller-1.

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
DX system with two controllers.

Branch/Pull Time/Commit
-----------------------
stx master

Last Pass
---------
N/A

Timestamp/Logs
--------------
See "Steps to Reproduce"

Test Activity
-------------
Developer Testing

Workaround
----------
Manually copy /opt/platform/config/21.05/etcd/ca.key to /etc/etcd/ directory on controller-1.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/805386

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/805386
Committed: https://opendev.org/starlingx/stx-puppet/commit/f88cda6b520b750795f13d3ec9b9fab25890acb5
Submitter: "Zuul (22348)"
Branch: master

commit f88cda6b520b750795f13d3ec9b9fab25890acb5
Author: Andy Ning <email address hidden>
Date: Thu Aug 19 09:43:53 2021 -0400

    Add missing etcd ca.key file during upgrade

    When a DX system is upgraded from 20.06 to 21.05, the etcd
    ca.key file is missing on controller-1. This change updated
    the upgrade runtime class in etcd.pp to copy the ca.key file
    to /etc/etcd directory.

    Closes-Bug: 1940661
    Signed-off-by: Andy Ning <email address hidden>
    Change-Id: Id91aa61261f653797bb63cc03648ecf97ae72d40