Kube Upgrade needs to raise/clear appropriate alarms based on its activity

Bug #1936372 reported by John Kung
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
John Kung

Bug Description

Brief Description
-----------------
There is an alarm defined for kube upgrade in progress
900.007 defined in fm-api ( FM_ALARM_ID_KUBE_UPGRADE_IN_PROGRESS)
however there is no code in sysinv to raise or clear that alarm.

Would be good to raise/clear the alarm so we are consistent between upgrades, patching, firmware
and k8s upgrade.

Note: When this is fixed, the VIM kube upgrade orchestration and DC kube upgrade orchestration should
also be re-tested to ensure the alarm does not block their execution.

Severity
--------

Minor: potential missing alarm; during orchestration there is a raised orchestration alarm
to indicate the state kube upgrade in progress; however, not if performed manually.

Steps to Reproduce
------------------

Start a kubernetes upgrade and check fm.
system kube-upgrade-start <some version>
fm alarm-list

Steps for setting up env to run a kubernetes upgrade are here:
https://docs.starlingx.io/configuration/k8s_upgrade.html

Expected Behavior
------------------
there should be an alarm (900.007)

Actual Behavior
----------------
no alarm for kube upgrade exists

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Can be done in any env that supports kube upgrade. (AIO-SX, AIO-DX or STD-DX)

Branch/Pull Time/Commit
-----------------------
June 14, 2021

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

There are no logs, because this is an enhancement rather than an error or a failure.

Test Activity
-------------
Code Inspection

Workaround
----------
No need for a workaround, although the alarm could be manually raised.

John Kung (john-kung)
Changed in starlingx:
assignee: nobody → John Kung (john-kung)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/800936

Changed in starlingx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.opendev.org/c/starlingx/config/+/800936
Committed: https://opendev.org/starlingx/config/commit/ae41f06407ba177d63afec21486a1c262cbf8c2d
Submitter: "Zuul (22348)"
Branch: master

commit ae41f06407ba177d63afec21486a1c262cbf8c2d
Author: John Kung <email address hidden>
Date: Thu Jul 15 07:47:15 2021 -0500

    Kube Upgrade: Raise and clear kube upgrade in progress alarm

    The fm alarm 900.007 "Kubernetes upgrade in progress." is raised on start
    of kubernetes upgrade and cleared on completion of kubernetes upgrade.

    Prior to this commit, the 900.007 (FM_ALARM_ID_KUBE_UPGRADE_IN_PROGRESS)
    alarm was not being raised. It is already in the VIM ignore list, so
    it does not prevent the orchestrated kube upgrade operations.

    Verified on manual and VIM orchestrated kubernetes upgrade.

    Change-Id: I97a6aa034acb4725f6a7a27f58b8e8aa311ece22
    Closes-Bug: 1936372
    Signed-off-by: John Kung <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
tags: added: stx.6.0 stx.distcloud stx.update
Changed in starlingx:
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.