stx-openstack install failing when using custom Horizon theme

[Thiago Ribeiro Carvalho]

- Brief Description

When trying to install containerized stx-openstack with custom Horizon theme, it was noticed that the install fails given the current config also loads the StarlingX theme and that fails because the theme is not available on the Openstack Horizon image.

- Severity

Major.

- Steps to Reproduce

    Install containerized stx-openstack with custom Horizon theme.
    Installation fails because it's missing StarlingX theme.

- Expected Behavior

stx-openstack with custom Horizon theme installed.

- Actual Behavior

Fails to install stx-openstack with custom Horizon theme installed.

- Reproducibility

100% (tried a few times in one lab).

- System Configuration

DX+6

- Timestamp/Logs

+ /tmp/manage.py collectstatic --noinput
/var/lib/openstack/lib64/python3.6/site-packages/scss/namespace.py:172: DeprecationWarning: inspect.getargspec() is deprecated since Python 3.0, use inspect.signature() or inspect.getfullargspec()
  argspec = inspect.getargspec(function)
Traceback (most recent call last):
  File "/tmp/manage.py", line 19, in <module>
    execute_from_command_line(sys.argv)
  File "/var/lib/openstack/lib/python3.6/site-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
    utility.execute()
  File "/var/lib/openstack/lib/python3.6/site-packages/django/core/management/__init__.py", line 375, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/var/lib/openstack/lib/python3.6/site-packages/django/core/management/base.py", line 323, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/var/lib/openstack/lib/python3.6/site-packages/django/core/management/base.py", line 364, in execute
    output = self.handle(*args, **options)
  File "/var/lib/openstack/lib/python3.6/site-packages/django/contrib/staticfiles/management/commands/collectstatic.py", line 188, in handle
    collected = self.collect()
  File "/var/lib/openstack/lib/python3.6/site-packages/django/contrib/staticfiles/management/commands/collectstatic.py", line 105, in collect
    for path, storage in finder.list(self.ignore_patterns):
  File "/var/lib/openstack/lib/python3.6/site-packages/django/contrib/staticfiles/finders.py", line 131, in list
    for path in utils.get_files(storage, ignore_patterns):
  File "/var/lib/openstack/lib/python3.6/site-packages/django/contrib/staticfiles/utils.py", line 23, in get_files
    directories, files = storage.listdir(location)
  File "/var/lib/openstack/lib/python3.6/site-packages/django/core/files/storage.py", line 315, in listdir
    for entry in os.scandir(path):
FileNotFoundError: [Errno 2] No such file or directory: '/var/lib/openstack/lib/python3.6/site-packages/openstack_dashboard/themes/starlingx'

- Workaround
Remove branding.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/openstack-armada-app/+/800485
Committed: https://opendev.org/starlingx/openstack-armada-app/commit/ab3b60c1972babeb724bc8d8d0bf3d52823af0f2
Submitter: "Zuul (22348)"
Branch: master

commit ab3b60c1972babeb724bc8d8d0bf3d52823af0f2
Author: Thiago Brito <email address hidden>
Date: Mon Jul 12 11:36:07 2021 -0300

    Fix custom horizon theme load

    When loading a custom theme, the current configuration also loads the
    StarlingX theme which is not available on the Openstack Horizon image.
    This fix removes the loading of the StarlingX theme and fixes the logic
    so other themes are enabled when the custom one is not.

    Closes-Bug: #1935859

    Signed-off-by: Thiago Brito <email address hidden>
    Change-Id: I14975ee07210875f0e5c49c13e3371a18c4b2261