wait_for_worker_config_init.sh is packaged in AIO systems

[Iago Regiani]

Brief Description
-----------------
The after the introduction of 'Single puppet manifest for AIO controllers' feature with https://review.opendev.org/c/starlingx/config/+/780603 there is still a query for worker config complete by wait_for_worker_config_init.sh which references the removed workerconfig.service and produces a warning log on AIO systems.

The fix for this issue should be to exclude packaging and calling wait_for_worker_config_init.sh during the init of an AIO controller.

Severity
--------
Minor

Steps to Reproduce
--------
Unlock AIO host

Expected Behavior
--------
wait_for_worker_config_init.sh should not be packaged or called on AIO controller

Actual Behavior
--------
wait_for_worker_config_init.sh is packaged and called on AIO controller

Reproducibility
--------
Reproducible

System Configuration
--------
AIO controller

Branch/Pull Time/Commit
--------
All loads after https://review.opendev.org/c/starlingx/config/+/780603 merged on April 22, 2021

Last Pass
--------
Unknown

Timestamp/Logs
--------
2021-06-14T18:03:05.171 controller-0 wait_for_worker_config_init.sh[5558]: info Unit workerconfig.service could not be found.
No system collect required. The above description details and log demonstrates what is going on.

Test Activity
--------
Developer Testing

Workaround:
--------
None and not required.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/799516

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/metal/+/800069

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Iago Rodriguez Regiani <email address hidden>" on branch: master
Review: https://review.opendev.org/c/starlingx/config/+/799516
Reason: Closing to submit a new review on metal repository

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/metal/+/800069
Committed: https://opendev.org/starlingx/metal/commit/adcbc03f2c0dd86214f9bbedf61c3f3a684fc998
Submitter: "Zuul (22348)"
Branch: master

commit adcbc03f2c0dd86214f9bbedf61c3f3a684fc998
Author: Iago Regiani <email address hidden>
Date: Thu Jul 8 10:38:40 2021 -0400

    Removed wait_for_worker_config_init in AIO systems

    After the introduction of the single puppet manifest file for AIO
    controllers https://review.opendev.org/c/starlingx/config/+/780603,
    the service worker-config-gate was still being packaged, producing
    a warning during execution.

    This removes workerconfig and config-gate-worker from AIO that
    calls wait_for_worker_config_init.sh

    Closes-Bug: #1934544
    Signed-off-by: Iago Regiani <email address hidden>
    Change-Id: Ib1e3a243a6bf286bb37dfbbbbd07995dba48cee5

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/update/+/804885