Restore fails when drbd filesystems exceed the cgts-vg size

[Mihnea Saracin]

Brief Description
-----------------

Restore playbook fails because the puppet manifest wants to create the docker-distribution-lv with a size of 100G exceeding the default cgts-vg size

Severity
--------

Critical

Steps to Reproduce
------------------

Install a system

Resize docker-distribution-lv or other drbd filesystem to 100G

Backup it

Run restore playbook

Expected Behavior
------------------

restore playbook succeeds

Actual Behavior
----------------

restore playbook fails

Reproducibility
---------------

100%

System Configuration
--------------------

AIO-SX, possible all configs

Branch/Pull Time/Commit
-----------------------

stx master build on "2021-06-10"

Last Pass
---------
N/A

Timestamp/Logs
--------------

# ansible log

TASK [bootstrap/apply-manifest : Fail if puppet manifest apply script returns an error] ***
fatal: []: FAILED! => {"changed": false, "msg": "Failed to apply bootstrap manifest. Please re-install before attempting to bootstrap it again. See /var/log/puppet/latest/puppet.log for details."}

# puppet log

2021-06-25T14:52:01.660 ^[[0;36mDebug: 2021-06-25 14:52:01 +0000 Executing: '/usr/sbin/lvs cgts-vg'^[[0m
2021-06-25T14:52:01.662 ^[[0;36mDebug: 2021-06-25 14:52:01 +0000 Executing: '/usr/sbin/vgs --noheading -o vg_extent_size --units k cgts-vg'^[[0m
2021-06-25T14:52:01.664 ^[[0;36mDebug: 2021-06-25 14:52:01 +0000 Executing: '/usr/sbin/lvcreate -n platform-lv --size 10485760k cgts-vg'^[[0m
2021-06-25T14:52:01.666 ^[[1;31mError: 2021-06-25 14:52:01 +0000 Execution of '/usr/sbin/lvcreate -n platform-lv --size 10485760k cgts-vg' returned 5: Volume group "cgts-vg" has insufficient free space (145 extents): 320 required.

Test Activity
-------------

Developer Testing

[Frank Miller (sensfan22)]

Removing tag stx.6.0 as this is a day 1 issue and only occurs when doing a restore after resizing a filesystem. This is not a high runner scenario. Would be good to have this fixed at some point but should not hold up the stx.6.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/859147

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/859148

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Mauricio Biasi do Monte Carmelo <email address hidden>" on branch: master
Review: https://review.opendev.org/c/starlingx/config/+/866414

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Mauricio Biasi do Monte Carmelo <email address hidden>" on branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/866341

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Felipe Sanches Zanoni <email address hidden>" on branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/859147
Reason: This code will no longer be necessary for master branch

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Felipe Sanches Zanoni <email address hidden>" on branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/859148
Reason: This code will no longer be necessary for master branch

[Ghada Khalil (gkhalil)]

Marking as Invalid as it appears that no fixes were actually required for this issue