oidc-armada-app is pointing to an old stx-oidc-client image

[Ghada Khalil]

Brief Description
-----------------
In January 2021, the stx-oidc-client image was rebuilt and retagged as stx.5.0-v1.0.4
https://review.opendev.org/c/starlingx/oidc-auth-armada-app/+/771051
https://review.opendev.org/c/starlingx/root/+/771497

However, the image reference in the helm chart was not updated to point to the correct version

Severity
--------
Medium - an older image has been unintentionally in use since Jan 2021.

Steps to Reproduce
------------------
- Populate a private registry with the images listed in the image-tags.yaml
- Attempt to deploy the oidc app

Expected Behavior
------------------
The oidc app should deploy successfully

Actual Behavior
----------------
The oidc app fails to download the stx-oidc-client image. The helm chart attempts to download v1.0.3 while the private registry is populated with v1.0.4

Reproducibility
---------------
Reproducible

System Configuration
--------------------
any

Branch/Pull Time/Commit
-----------------------
stx master. This is an issue in stx.5.0 as well, but given the older image is also functional, there is no issue with continuing to use it. However, users will have to push it to their private registries

Last Pass
---------
Did this test scenario pass previously? If so, please indicate the load/pull time info of the last pass.
Use this section to also indicate if this is a new test scenario.

Timestamp/Logs
--------------
sysinv 2021-06-11 21:07:55.528 480964 INFO sysinv.conductor.kube_app [-] Failed to download image: registry.local:9001/docker.io/starlingx/stx-oidc-client:stx.5.0-v1.0.3

Test Activity
-------------
Other

Workaround
----------
Push stx-oidc-client:stx.5.0-v1.0.3 to the private registry

[Ghada Khalil (gkhalil)]

screening: stx.6.0 - this should be fixed in the stx active branch

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/oidc-auth-armada-app/+/796455

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/oidc-auth-armada-app/+/796455
Committed: https://opendev.org/starlingx/oidc-auth-armada-app/commit/7cd7316b1e58bea1398f9aa1db56c1b776b18446
Submitter: "Zuul (22348)"
Branch: master

commit 7cd7316b1e58bea1398f9aa1db56c1b776b18446
Author: Teresa Ho <email address hidden>
Date: Mon Jun 14 13:44:30 2021 -0400

    Update image tag for stx-oidc-client

    Change image tag from stx.5.0-v1.0.3 to stx.5.0-v1.0.4

    Closes-Bug: 1931753

    Change-Id: I5bf80c31d77c354ea901a509e4fa7e042b0c1cfd
    Signed-off-by: Teresa Ho <email address hidden>