bogus sm logs falsely complain service enable timeout

[Bin Qian]

Brief Description

the following log pattern are log in sm.log, falsely complain the services enable timeout

2021-06-10T17:12:02.000 controller-0 sm: debug time[86698.094] log<28081> INFO: sm[89489]: sm_service_enabled_active_state.c(374): Service (sysinv-inv) ignoring event (enable-timeout).
2021-06-10T17:12:02.000 controller-0 sm: debug time[86698.094] log<28082> INFO: sm[89489]: sm_service_enabling_state.c(83): Service (sysinv-inv) enabling overall timeout.

Severity

Major: This does not impact functionality, but it flood the log file every 5 minutes.

Steps to Reproduce

reproducible in any stx.5.0 load and on stx master

Expected Behavior

The log shouldn't appear for the services not enabling timeout.

Reproducibility

100%

System Configuration
Any

Last Pass

was not seen it previous release

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ha/+/795868

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ha/+/795868
Committed: https://opendev.org/starlingx/ha/commit/0288e26cca460353956301f2160cc790b6947faa
Submitter: "Zuul (22348)"
Branch: master

commit 0288e26cca460353956301f2160cc790b6947faa
Author: Bin Qian <email address hidden>
Date: Thu Jun 10 15:35:53 2021 -0400

    Fix: bogus sm logs falsely complain service enable timeout

    This fix service enabling timeout timer incorrect left active after service is
    enabled.
    Also ensure properly transitioning to service enabling state from enabling-throttle
    state (transition logging).

    Closes-Bug: 1931617
    Signed-off-by: Bin Qian <email address hidden>
    Change-Id: I0be01c335ef9e39d1f14df12cccdf97ce09fbb5c

[Ghada Khalil (gkhalil)]

screening: low / would be nice to fix, but not gating any release