vim service unexpected enabled before platform-fs

[Bin Qian]

In some rare cases, vim service is enabled before platform-fs service. The result is that vim service does not run properly.

Severity
--------
Major: vim is critical for system functionalities

Steps to Reproduce
------------------
swact between controllers.

Reproducibility
---------------
very low

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ha/+/792189

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ha/+/792189
Committed: https://opendev.org/starlingx/ha/commit/d34896248a88e5da03b93385949aa7ec2dae1e37
Submitter: "Zuul (22348)"
Branch: master

commit d34896248a88e5da03b93385949aa7ec2dae1e37
Author: Bin Qian <email address hidden>
Date: Mon May 17 13:48:04 2021 -0400

    Fix: accidentally enable service before dependency

    Currently when a controller goes active, a chain operations of setting
    desired state of each service domain assignment (group) to
    "enabled-active", and each service within the group to "enabled-active",
    which triggers a service going enabled, where service enabled dependency
    is being checked. However some groups still have desired state
    "enabled-standby", which allows a dependency being met when the service
    is still in "disabled" state.

    Ensure setting all services group desired state to target state before
    enabling services.

    Closes-Bug: 1928707
    Signed-off-by: Bin Qian <email address hidden>
    Change-Id: Id38540bc0a5292602ae49c524b0dceb77e303a8b

[Ghada Khalil (gkhalil)]

screening: stx.6.0 / medium - highly intermittent issue; to be fixed in the active branch