node-feature-discovery pod fails when trying to run helm install

[Chris Friesen]

When running "helm install node-feature-discovery-my-name /opt/extracharts/node-feature-discovery-0.3.0.tgz" the chart gets installed but the pod shows errors like the following:

2021-04-28T16:33:11.086665904Z stderr F 2021/04/28 16:33:11 failed to get node: v1.Node: ObjectMeta: v1.ObjectMeta: readObjectFieldAsBytes: expect : after object field, parsing 1401 ...":{},"v:\"... at {"kind":"Node","apiVersion":"v1","metadata":

2021-04-28T16:33:11.086746434Z stderr F 2021/04/28 16:33:11 error occurred while updating node with feature labels: v1.Node: ObjectMeta: v1.ObjectMeta: readObjectFieldAsBytes: expect : after object field, parsing 1401 ...":{},"v:\"... at {"kind":"Node","apiVersion":"v1","metadata":

It looks like the chart hasn't been updated in a while and needs to be updated.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/helm-charts/+/790001

[Ghada Khalil (gkhalil)]

screening: issue with an optional / peripheral feature, so given the imminent stx.5.0 release date, it's sufficient to fix in stx master only and not cherry-pick to the r/stx.5.0 release branch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/docs/+/790698

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/helm-charts/+/790001
Committed: https://opendev.org/starlingx/helm-charts/commit/573c5acfe8378565914fdf45c5100334bcf47ec4
Submitter: "Zuul (22348)"
Branch: master

commit 573c5acfe8378565914fdf45c5100334bcf47ec4
Author: Chris Friesen <email address hidden>
Date: Wed May 5 18:19:27 2021 -0600

    Update node-feature-discovery helm chart to current version

    The existing helm chart for "node feature discovery" seems to be
    out of date and doesn't run properly. Updating it to the current
    version (v0.8.1) seems to fix things.

    The upstream code now has a helm chart, so I've aligned with it
    to simplify porting in the future.

    I made one change from the upstream code, I set the chart version to
    0.8.1 to match the git tag and chart appVersion. This ensures that the
    chart tarball is versioned appropriately.

    At some point we could modify the build system for this chart to
    use a "git repo + patches" approach rather than duplicating the
    chart like I've done here. This is out of scope for this commit
    however.

    Closes-Bug: 1927289
    Signed-off-by: Chris Friesen <email address hidden>
    Change-Id: I8d9b6830a3852ae269b70c0e9d42ea8abf4e9458

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/docs/+/790698
Committed: https://opendev.org/starlingx/docs/commit/53e16e3422f35aa5d9bf59fc4ebcd10c61e7d20e
Submitter: "Zuul (22348)"
Branch: master

commit 53e16e3422f35aa5d9bf59fc4ebcd10c61e7d20e
Author: egoncalv <email address hidden>
Date: Tue May 11 10:35:32 2021 -0300

    Modified steps 2 and 3.

    Closes-Bug: 1927289

    Signed-off-by: egoncalv <email address hidden>
    Change-Id: I410729529ec4c954f76569c4fd0cd4c258bae432

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.5.0
Review: https://review.opendev.org/c/starlingx/docs/+/797490

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/docs/+/797490
Committed: https://opendev.org/starlingx/docs/commit/2342c834e049ba7720f14c46bc3bdf612d9806f9
Submitter: "Zuul (22348)"
Branch: r/stx.5.0

commit 2342c834e049ba7720f14c46bc3bdf612d9806f9
Author: egoncalv <email address hidden>
Date: Tue May 11 10:35:32 2021 -0300

    Modified steps 2 and 3.

    Closes-Bug: 1927289

    Signed-off-by: egoncalv <email address hidden>
    Change-Id: I410729529ec4c954f76569c4fd0cd4c258bae432
    (cherry picked from commit 53e16e3422f35aa5d9bf59fc4ebcd10c61e7d20e)