Cant modify the interface without lock/unlock through GUI, in AIO-SX

Bug #1925183 reported by Andre Kantek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
Andre Kantek

Bug Description

Brief Description
-----------------
With the completion of storyboard 2008531 it was expected to be able to modify an ethernet interface from Horizon's GUI when in AIO-SX configuration, as it is possible to do it via system CLI

Severity
--------
Minor: System/Feature is usable with a minor issue

Steps to Reproduce
------------------
1)goto https://[ip]:8443
2)goto host inventory->interfaces, the create, edit tab only gets enabled if the host is locked but with the "system interface modify" without lock/unlock, it should be enabled for the user to modify the interfaces

Expected Behavior
------------------
User should be able to edit the interface if ethernet and AIO-SX

Actual Behavior
----------------
User cannot edit the interface if ethernet and AIO-SX

Reproducibility
---------------
Reproducible

System Configuration
--------------------
AIO-SX

Branch/Pull Time/Commit
-----------------------
latest on master.

Last Pass
---------
Unknown

Timestamp/Logs
--------------
See steps to reproduce.

Test Activity
-------------
Developer Testing

Workaround
----------
Modify the ethernet interface using system CLI

Andre Kantek (akantek)
Changed in starlingx:
assignee: nobody → Andre Kantek (akantek)
status: New → In Progress
Andre Kantek (akantek)
summary: - Cant modify the interface without lock/unlock through GUI
+ Cant modify the interface without lock/unlock through GUI, in AIO-SX
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gui (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/gui/+/787192

Revision history for this message
Ghada Khalil (gkhalil) wrote :

screening: minor/low; should fix in stx master for the next, but no need to cherrypick to the r/stx.5.0 release as there is a workaround to use the CLI.
Note: This is related to story: https://storyboard.openstack.org/#!/story/2008531

tags: added: stx.gui stx.networking
Changed in starlingx:
importance: Undecided → Low
importance: Low → Medium
importance: Medium → Low
tags: added: stx.6.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gui (master)

Reviewed: https://review.opendev.org/c/starlingx/gui/+/787192
Committed: https://opendev.org/starlingx/gui/commit/180d8a7dcc78d1e9b10df4c103f95d32b116bb0e
Submitter: "Zuul (22348)"
Branch: master

commit 180d8a7dcc78d1e9b10df4c103f95d32b116bb0e
Author: Andre Fernando Zanella Kantek <email address hidden>
Date: Tue Apr 20 07:10:46 2021 -0400

    Cant modify the interface without lock/unlock through GUI, in AIO-SX

    As part of storyboard 2008531 users should be able to modify the
    ethernet interface to SR-IOV from the CLI and Horizon's GUI. This
    correction enables the "Edit Interface" button if the system is
    AIO-SX, the interface is ethernet and the class isn't pci-sriov.

    Tested with GUI on AIO-SX and Standard setups as described on
    launchpad

    Closes-Bug: 1925183

    Signed-off-by: Andre Fernando Zanella Kantek <email address hidden>
    Change-Id: Ic60684eae123618506d15c8564a85230df7a605d

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
Andre Kantek (akantek) wrote :

Detected a missing implementation on the previous correction, the user cannot add/delete sriov-vf interfaces

Brief Description
-----------------
On an unlocked AIO-SX system, the GUI should allow the creation/deletion of SRIOV-VF interfaces

Severity
--------
Minor: System/Feature is usable with a minor issue

Steps to Reproduce
------------------
1)goto https://[ip]:8443
2)goto host inventory->interfaces, the create, and delete buttons gets enabled if the host is locked

Expected Behavior
------------------
User should be able to create and delete the interface if sriov-vf and unlocked AIO-SX

Actual Behavior
----------------
User cannot create/delete the interface if SRIOV-VF and AIO-SX

Reproducibility
---------------
Reproducible

System Configuration
--------------------
AIO-SX

Branch/Pull Time/Commit
-----------------------
latest on master.

Last Pass
---------
Unknown

Timestamp/Logs
--------------
See steps to reproduce.

Test Activity
-------------
Developer Testing

Workaround
----------
Create and delete the interface using system CLI

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gui (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/gui/+/788712

Ghada Khalil (gkhalil)
Changed in starlingx:
status: Fix Released → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gui (master)

Reviewed: https://review.opendev.org/c/starlingx/gui/+/788712
Committed: https://opendev.org/starlingx/gui/commit/de43c019c0b7f038d0184d10aab2bf61b6c5e147
Submitter: "Zuul (22348)"
Branch: master

commit de43c019c0b7f038d0184d10aab2bf61b6c5e147
Author: Andre Fernando Zanella Kantek <email address hidden>
Date: Thu Apr 29 06:33:50 2021 -0400

    On AIO-SX's GUI, allow create/delete buttons for SRIOV-VF interfaces

    As part of the correction for this bug the user must be capable,
    through GUI, to create and delete subinterfaces on an unlocked system
    to handle SRIOV-VF interfaces, as it is permitted via CLI

    If the system is unlocked, a logic was added to prevent the create
    button to be displayed if no SRIOV-PF interface is present. The
    delete button will also only be shown if it is a SRIOV-VF interface

    Closes-Bug: 1925183

    Signed-off-by: Andre Fernando Zanella Kantek <email address hidden>
    Change-Id: I985383292affee5e1627b2c0c9a6455d16bbdfec

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gui (r/stx.5.0)

Fix proposed to branch: r/stx.5.0
Review: https://review.opendev.org/c/starlingx/gui/+/788920

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on gui (r/stx.5.0)

Change abandoned by "Andre Kantek <email address hidden>" on branch: r/stx.5.0
Review: https://review.opendev.org/c/starlingx/gui/+/788920
Reason: No need to cherry-pick on 5.0

Ghada Khalil (gkhalil)
Changed in starlingx:
status: Fix Released → In Progress
Revision history for this message
Andre Kantek (akantek) wrote :

It was detected that when the user applies the edit to the server when the AIO-SX is unlocked, it is being rejected, with the error cause "Host is in unlocked state"

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gui (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/gui/+/790043

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gui (master)

Reviewed: https://review.opendev.org/c/starlingx/gui/+/790043
Committed: https://opendev.org/starlingx/gui/commit/7973677a3d7d518c31757b36037373d2c4ac769c
Submitter: "Zuul (22348)"
Branch: master

commit 7973677a3d7d518c31757b36037373d2c4ac769c
Author: Andre Fernando Zanella Kantek <email address hidden>
Date: Thu May 6 07:32:59 2021 -0400

    In AIO-SX, interface edit rejected with Host administrative unlocked

    It was detected the edit rejection when the user, on an unlocked
    host, tries to convert an ethernet non-SRIOV to an SRIOV-PF
    interface, with the server responding "Host 'controller-0' is
    administrative 'unlocked'".

    This is caused because UpdateInterface.handle() executes first the
    datanetwork assignment and then modifies the interface. Since the
    assignment, on an unlocked host, is only possible for SRIOV
    interfaces, the order of execution matters, we need to have the
    interface modified and then assigned. The correction consists of
    altering the order (first modify then assign) to do the described.

    Tests:
    To ensure the continuous operation of the other types of conversion
    the following combinations were tested (all were done adding the
    interface to a network or datanetwork, depending on the class):

    Unlocked state:
    ethernet/[none,data,pci-pt,platform] to pci-sriov: accepted
    modify parameters of a pci-sriov: rejected
    conversion to other than pci-sriov: rejected

    Locked state:
    all conversions (with network/datanetwork assignment) are accepted

    Closes-Bug: 1925183

    Signed-off-by: Andre Fernando Zanella Kantek <email address hidden>
    Change-Id: Ib124bf7222e07966becbb81198f65f5bc55715ce

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gui (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/gui/+/792252

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gui (f/centos8)
Download full text (16.7 KiB)

Reviewed: https://review.opendev.org/c/starlingx/gui/+/792252
Committed: https://opendev.org/starlingx/gui/commit/63d6de4701a7f21779ad9ea4060fce9ed85bc71f
Submitter: "Zuul (22348)"
Branch: f/centos8

commit e05e1a43531499d94cfb1e538683ee36eea92b43
Author: Teresa Ho <email address hidden>
Date: Thu May 13 23:04:04 2021 -0400

    Do not display primary_reselect if not specified

    If the attribute 'primary_reselect' is not specified, the sysinv API
    will leave it as null and GUI will not display the attribute.

    Closes-Bug: 1928461

    Change-Id: I5b8ef8b29fb7775dde8607bb14cd733015269f82
    Signed-off-by: Teresa Ho <email address hidden>

commit f1a4d30eca91c7a239ebd7479a56fef7870a4b2e
Author: Pablo Bovina <email address hidden>
Date: Fri May 7 16:59:50 2021 -0300

    Display DataNetworks list

    DataNetworks are listed for pci-sriov
    under Create/Edit Interface forms.

    Closes-bug: 1927782
    Signed-off-by: Pablo Bovina <email address hidden>
    Change-Id: If927bb0facdec9e587a13354bef56eca5df08785

commit 7973677a3d7d518c31757b36037373d2c4ac769c
Author: Andre Fernando Zanella Kantek <email address hidden>
Date: Thu May 6 07:32:59 2021 -0400

    In AIO-SX, interface edit rejected with Host administrative unlocked

    It was detected the edit rejection when the user, on an unlocked
    host, tries to convert an ethernet non-SRIOV to an SRIOV-PF
    interface, with the server responding "Host 'controller-0' is
    administrative 'unlocked'".

    This is caused because UpdateInterface.handle() executes first the
    datanetwork assignment and then modifies the interface. Since the
    assignment, on an unlocked host, is only possible for SRIOV
    interfaces, the order of execution matters, we need to have the
    interface modified and then assigned. The correction consists of
    altering the order (first modify then assign) to do the described.

    Tests:
    To ensure the continuous operation of the other types of conversion
    the following combinations were tested (all were done adding the
    interface to a network or datanetwork, depending on the class):

    Unlocked state:
    ethernet/[none,data,pci-pt,platform] to pci-sriov: accepted
    modify parameters of a pci-sriov: rejected
    conversion to other than pci-sriov: rejected

    Locked state:
    all conversions (with network/datanetwork assignment) are accepted

    Closes-Bug: 1925183

    Signed-off-by: Andre Fernando Zanella Kantek <email address hidden>
    Change-Id: Ib124bf7222e07966becbb81198f65f5bc55715ce

commit ddcc4fd3ccb4c02580c71414345993252b089761
Author: Enzo Candotti <email address hidden>
Date: Tue May 4 11:08:57 2021 -0300

    Enable add/edit Worker personality on DC AIO-DX's GUI

    This update is to allow the option to add a new host with Worker
    personality on Distributed Cloud mode.

    Closes-Bug: 1927107

    Signed-off-by: Enzo Candotti <email address hidden>
    Change-Id: Idfed9352c7c6467014a2ed2cf10b70f6b470c28c

commit de43c019c0b7f038d0184d10aab2bf61b6c5e147
Author: Andre Fer...

tags: added: in-f-centos8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.