oidc-client doesn't handle helm-overrides while running

[Jerry Sun]

Brief Description
-----------------
oidc-client configuration changes through helm-overrides are not picked up on a running pod. If oidc-auth-apps is applied and config changes are made through helm overrides, oidc-client still uses the old config.

Severity
--------
Major: System/Feature is usable but degraded

Steps to Reproduce
------------------
apply oidc-auth-apps, change oidc-client config through helm overrides, observe the behavior of the oidc-client

Expected Behavior
------------------
new oidc-client config

Actual Behavior
----------------
old oidc-client config

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Multi-node system

Branch/Pull Time/Commit
-----------------------
Pull 2021-04-13

Last Pass
---------
no

Workaround
----------
remove the application and apply the application.
alternatively, find all the oidc-client pods and delete them to force a pod restart to pick up the new config.

[Jerry Sun (jerry-sun-u)]

change up for review:
https://review.opendev.org/c/starlingx/oidc-auth-armada-app/+/786118

[Ghada Khalil (gkhalil)]

stx.5.0 / medium - would be nice to fix, but given there is a workaround, this is not considered high severity.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/oidc-auth-armada-app/+/786118
Committed: https://opendev.org/starlingx/oidc-auth-armada-app/commit/4b899cefd89963bc09a9e3ac32828421f1381944
Submitter: "Zuul (22348)"
Branch: master

commit 4b899cefd89963bc09a9e3ac32828421f1381944
Author: Jerry Sun <email address hidden>
Date: Tue Apr 13 16:09:43 2021 -0400

    oidc-client pod does not properly pick up new config

    A config update through helm overrides to oidc-client gets properly
    passed to the pod, however, the pod does not restart to pick up the
    new config. This commit adds annotations to the oidc-client pod to
    track config changes and trigger a pod restart through kubernetes if
    the config changes. This is only relevant to pods already deployed on
    an applied application. Helm overrides are correctly applied if they
    are changed first, then the application applied.

    Change-Id: I3d9f48038305283a836827fcebcc2b4e95921147
    Closes-Bug: 1923662
    Signed-off-by: Jerry Sun <email address hidden>

[Ghada Khalil (gkhalil)]

Confirmed that this fix was picked up in the r/stx.5.0 release branch
https://review.opendev.org/plugins/gitiles/starlingx/oidc-auth-armada-app/+log/refs/heads/r/stx.5.0/