platform-integ-apps and rook-ceph-apps plugins are incorrectly packaged together

[Bob Church]

Brief Description
-----------------
An error is observed during the application lifecycle which indicates that rook-ceph-apps has the plugins for platform-integ-apps present in the application tarball.

sysinv 2021-03-18 08:46:56.927 101102 INFO sysinv.conductor.kube_app [-] PluginHelper: Disabled plugin directory /opt/platform/helm/20.12/rook-ceph-apps/1.0-3/plugins: removed /usr/lib64/python2.7/site-packages/stx_app-rook-ceph-apps-1.0-3.pth
sysinv 2021-03-18 08:46:56.927 101102 INFO sysinv.conductor.kube_app [-] PluginHelper: Disabling distributions: [u'k8sapp-rook', u'k8sapp-platform']

This is indicative of an application building issue that is not properly isolating plugins when building the application tarball for inclusion in the RPM

I suspect that this is dependent on the build order of the packages and if the application RPMs are built in the same mock env.

$ tree -L 2 ./controller-0_20210318.141544/var/extra/platform/helm/20.12/rook-ceph-apps/1.0-3/plugins
./controller-0_20210318.141544/var/extra/platform/helm/20.12/rook-ceph-apps/1.0-3/plugins
├── k8sapp_platform
│ ├── armada
│ ├── common
│ ├── helm
│ ├── _init_.py
│ ├── _init_.pyc
│ ├── lifecycle
│ └── tests
├── k8sapp_platform-1.0.dist-info
│ ├── entry_points.txt
│ ├── METADATA
│ ├── RECORD
│ ├── top_level.txt
│ └── WHEEL
├── k8sapp_rook
│ ├── armada
│ ├── common
│ ├── helm
│ ├── _init_.py
│ ├── _init_.pyc
│ ├── lifecycle
│ └── tests
└── k8sapp_rook-1.0.dist-info
├── entry_points.txt
├── METADATA
├── RECORD
├── top_level.txt
└── WHEEL

Severity
--------
Provide the severity of the defect.
Major: System/Feature is usable but degraded

Steps to Reproduce
------------------
Upload rook-ceph-app
Upload platform-integ-apps

Expected Behavior
------------------
Both applications upload successfully

Actual Behavior
----------------
+--------------------------+---------+-----------------------------------+----------------------------------------+---------------+---------------------------------------+
| application | version | manifest name | manifest file | status | progress |
+--------------------------+---------+-----------------------------------+----------------------------------------+---------------+---------------------------------------+
| cert-manager | 1.0-13 | cert-manager-manifest | certmanager-manifest.yaml | applied | completed |
| nginx-ingress-controller | 1.0-11 | nginx-ingress-controller-manifest | nginx_ingress_controller_manifest.yaml | applied | completed |
| oidc-auth-apps | 1.0-37 | oidc-auth-manifest | manifest.yaml | uploaded | completed |
| platform-integ-apps | 1.0-23 | platform-integration-manifest | manifest.yaml | upload-failed | operation aborted, check logs for |
| | | | | | detail |
| | | | | | |
| rook-ceph-apps | 1.0-3 | rook-ceph-manifest | manifest.yaml | uploaded | completed |
+--------------------------+---------+-----------------------------------+----------------------------------------+---------------+---------------------------------------+

Reproducibility
---------------
Unknown

System Configuration
--------------------
Any

Branch/Pull Time/Commit
-----------------------
Branch and the time when code was pulled or git commit or cengn load info

Last Pass
---------

Timestamp/Logs
--------------

Test Activity
-------------
Sanity

Workaround
----------
None

[Bob Church (rchurch)]

Posted proposed fixes:
 - https://review.opendev.org/c/starlingx/rook-ceph/+/781589
 - https://review.opendev.org/c/starlingx/platform-armada-app/+/781588

[Bob Church (rchurch)]

Fixes merged:
 - https://opendev.org/starlingx/rook-ceph/commit/181b3fe6b3d4f03a358c6ace0325897a422cc9e4
 - https://opendev.org/starlingx/platform-armada-app/commit/45fd0a6b2cd2dbaaf7ff21ef989824377c5b17dc

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/platform-armada-app/+/792234

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/platform-armada-app/+/792234
Committed: https://opendev.org/starlingx/platform-armada-app/commit/f3bb236173d8bb336513a868d36f601a23ab87dc
Submitter: "Zuul (22348)"
Branch: f/centos8

commit 66fa48f04d926848a37f5fbb7689cf4b114cb3ba
Author: Pedro Henrique Linhares <email address hidden>
Date: Tue Apr 6 21:45:28 2021 -0300

    Update helm charts config maps after sx-dx migration with new CEPH monitors

    This commit adds annotations that allows config maps to be recreated
    after ceph monitor IP changes due to DX migration so that existing
    StorageClasses can get a reference to the correct monitor. StorageClasses
    and provisioners are recreated during platform-integ-apps auto re-apply.

    Story: 2008587
    Task: 42242

    Signed-off-by: Pedro Linhares <email address hidden>
    Depends-On: https://review.opendev.org/c/starlingx/stx-puppet/+/783727
    Change-Id: I9cedc70326e92796f03520deed7f0857e119257f

commit 9d45149d29b8c05808bcd7e5a129f135b3386931
Author: Isac Souza <email address hidden>
Date: Mon Apr 5 11:07:21 2021 -0300

    Use new method for setting num of replicas

    Use the new _num_replicas_for_platform_app method from the
    helm base class to set the number of replicas in the chart.
    The new method will return the number of provisioned
    controllers with a minimum of 1.

    Tested by building an ISO and installing the armada apps.

    Partial-Bug: 1922278
    Signed-off-by: Isac Souza <email address hidden>
    Change-Id: Idb3c93274a1cb5c410d885d459784382525427a0

commit 1021d50142af6422c9a3f0853f4b7c525e724ab8
Author: Daniel Safta <email address hidden>
Date: Wed Mar 24 12:56:29 2021 +0000

    Removed extra serviceAccount from cephfs-provisioner

    cephfs-provisioner may need to create new resources
    in the kubernetes cluster. It was granted access to
    some of the resources including namespaces but when
    https://review.opendev.org/c/starlingx/platform-armada-app/+/778746
    got merged the serviceAccount was changed.

    I have updated the serviceAccount with access to
    creating new namespaces and secrets.

    The serviceAccount that was initially used to create
    namespaces and secrets is not needed anymore, so I
    have removed it.

    Closes-bug: 1921197
    Change-Id: I3c683776f3ecaf9c78d1a6b5b1108e9582497dde
    Signed-off-by: Daniel Safta <email address hidden>

commit 45fd0a6b2cd2dbaaf7ff21ef989824377c5b17dc
Author: Robert Church <email address hidden>
Date: Thu Mar 18 11:43:21 2021 -0400

    Build: Isolate platform plugins to an app specific directory

    When building the stx-platform-helm RPM for platform-integ-apps the helm
    plugins are installed in a location that could be populated with other
    app plugins if their spec files are not properly set up.

    Adjust the spec to provide an app specific location for the plugins to
    ensure that no other app plugins are included in the application tarball

    Closes-Bug: #1920066
    Change-Id: Id24227cd100a3c29809f1dd01f61ea717...