Adding bare-metal Ceph storage backend at runtime fails

[Bob Church]

Brief Description
-----------------
Install: AIO-DX

Scenario: Fully provision an AIO-DX then add the Ceph storage backend

$ system storage-backend-add ceph --confirmed
System configuration has changed.
Please follow the administrator guide to complete configuring the system.
+--------------------------------------+------------+---------+-------------+--------------------------------------------------------------------------------+----------+---------------------------------+
| uuid | name | backend | state | task | services | capabilities |
+--------------------------------------+------------+---------+-------------+--------------------------------------------------------------------------------+----------+---------------------------------+
| b1ff3a00-6bb3-4751-8f54-7ad4691f77dd | ceph-store | ceph | configuring | {u'controller-1': 'applying-manifests', u'controller-0': 'applying-manifests'} | None | min_replication: 1 replication: |
| | | | | | | 2 |
| | | | | | | |
+--------------------------------------+------------+---------+-------------+--------------------------------------------------------------------------------+----------+---------------------------------+

This produces a puppet failure

2021-03-11T18:09:49.811 Debug: 2021-03-11 18:09:47 +0000 importing '/usr/share/puppet/modules/platform/manifests/rook.pp' in environment production
2021-03-11T18:09:49.814 Debug: 2021-03-11 18:09:47 +0000 Automatically imported platform::rook::params from platform/rook into production
2021-03-11T18:09:49.816 Error: 2021-03-11 18:09:47 +0000 Evaluation Error: Unknown variable: '::platform::rook::params::service_enabled'. at /usr/share/puppet/modules/platform/manifests/sm.pp:1134:22 on node controller-0
2021-03-11T18:09:49.819 /usr/share/ruby/vendor_ruby/puppet/pops/evaluator/runtime3_support.rb:39:in `optionally_fail'
2021-03-11T18:09:49.821 /usr/share/ruby/vendor_ruby/puppet/pops/evaluator/runtime3_support.rb:99:in `get_variable_value'
2021-03-11T18:09:49.824 /usr/share/ruby/vendor_ruby/puppet/pops/evaluator/evaluator_impl.rb:1041:in `eval_VariableExpression'
2021-03-11T18:09:49.826 /usr/share/ruby/vendor_ruby/puppet/pops/visitor.rb:69:in `visit_this_1'

Resulting the failed addition of the storage backend

$ system storage-backend-list
+--------------------------------------+------------+---------+----------------------+------+----------+---------------------------------------------------------------------------+
| uuid | name | backend | state | task | services | capabilities |
+--------------------------------------+------------+---------+----------------------+------+----------+---------------------------------------------------------------------------+
| b1ff3a00-6bb3-4751-8f54-7ad4691f77dd | ceph-store | ceph | configuration-failed | None | None | min_replication: 1 replication: 2 |
| | | | | | | |
+--------------------------------------+------------+---------+----------------------+------+----------+---------------------------------------------------------------------------+

Severity
--------
Provide the severity of the defect.
Critical: System/Feature is not usable due to the defect

Steps to Reproduce
------------------
See Description

Expected Behavior
------------------
The Ceph storage backend should be successfully provisioned at runtime

Actual Behavior
----------------
A puppet error leaves the backend in a configuration-failed state

Reproducibility
---------------
100%

System Configuration
--------------------
Two node systems

Branch/Pull Time/Commit
-----------------------
Build:
###
### StarlingX
### Built from master
###OS="centos"
SW_VERSION="20.12"
BUILD_TARGET="Host Installer"
BUILD_TYPE="Formal"
BUILD_ID="20210304T053000Z"JOB="STX_build_master_master"
<email address hidden>"
BUILD_NUMBER="845"
BUILD_HOST="starlingx_mirror"
BUILD_DATE="2021-03-04 05:30:00 +0000"

Last Pass
---------
Unsure but probably prior to commit https://opendev.org/starlingx/stx-puppet/commit/ce66ffd30cb33f2b770587d7731732e34593e8f1 being introduced

Timestamp/Logs
--------------
See snippet of puppet logs above

Test Activity
-------------
Developer Testing for a Ceph feature

Workaround
----------
None

[Bob Church (rchurch)]

Fix posted: https://review.opendev.org/c/starlingx/stx-puppet/+/780702

[Bob Church (rchurch)]

Fix available: https://opendev.org/starlingx/stx-puppet/commit/1aef5b8968d8ce28c4fbc42a5160f77a8ebff642

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/792009

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/792009

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/792013

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/792013

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/792018

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/792018

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/792029

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/792029
Committed: https://opendev.org/starlingx/stx-puppet/commit/2b026190a3cb6d561b6ec4a46dfb3add67f1fa69
Submitter: "Zuul (22348)"
Branch: f/centos8

commit 3e3940824dfb830ebd39fd93265b983c6a22fc51
Author: Dan Voiculeasa <email address hidden>
Date: Thu May 13 18:03:45 2021 +0300

    Enable kubelet support for pod pid limit

    Enable limiting the number of pids inside of pods.

    Add a default value to protect against a missing value.
    Default to 750 pids limit to align with service parameter default
    value for most resource consuming StarlingX optional app (openstack).
    In fact any value above service parameter minimum value is good for the
    default.

    Closes-Bug: 1928353
    Signed-off-by: Dan Voiculeasa <email address hidden>
    Change-Id: I10c1684fe3145e0a46b011f8e87f7a23557ddd4a

commit 0c16d288fbc483103b7ba5dad7782e97f59f4e17
Author: Jessica Castelino <email address hidden>
Date: Tue May 11 10:21:57 2021 -0400

    Safe restart of the etcd SM service in etcd upgrade runtime class

    While upgrading the central cloud of a DC system, activation failed
    because there was an unexpected SWACT to controller-1. This was due
    to the etcd upgrade script. Part of this script runs the etcd
    manifest. This triggers a reload/restart of the etcd service. As this
    is done outside of the sm, sm saw the process failure and triggered
    the SWACT.

    This commit modifies platform::etcd::upgrade::runtime puppet class
    to do a safe restart of the etcd SM service and thus, solve the
    issue.

    Change-Id: I3381b6976114c77ee96028d7d96a00302ad865ec
    Signed-off-by: Jessica Castelino <email address hidden>
    Closes-Bug: 1928135

commit eec3008f600aeeb69a42338ed44332228a862d11
Author: Mihnea Saracin <email address hidden>
Date: Mon May 10 13:09:52 2021 +0300

    Serialize updates to global_filter in the AIO manifest

    Right now, looking at the aio manifest:
    https://review.opendev.org/c/starlingx/stx-puppet/+/780600/15/puppet-manifests/src/manifests/aio.pp
    there are 3 classes that update
    in parallel the lvm global_filter:
    - include ::platform::lvm::controller
    - include ::platform::worker::storage
    - include ::platform::lvm::compute
    And this generates some errors.

    We fix this by adding dependencies between the above classes
    in order to update the global_filter in a serial mode.

    Closes-Bug: 1927762
    Signed-off-by: Mihnea Saracin <email address hidden>
    Change-Id: If6971e520454cdef41138b2f29998c036d8307ff

commit 97371409b9b2ae3f0db6a6a0acaeabd74927160e
Author: Steven Webster <email address hidden>
Date: Fri May 7 15:33:43 2021 -0400

    Add SR-IOV rate-limit dependency

    Currently, the binding of an SR-IOV virtual function (VF) to a
    driver has a dependency on platform::networking. This is needed
    to ensure that SR-IOV is enabled (VFs created) before actually
    doing the bind.

    This dependency does not exist for configuring the VF rate-limits
    however. There is a cha...